You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by xunzhang <gi...@git.apache.org> on 2016/12/02 16:05:57 UTC
[GitHub] incubator-hawq pull request #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized...
GitHub user xunzhang opened a pull request:
https://github.com/apache/incubator-hawq/pull/1035
HAWQ-1187. Fix "-Wsometimes-uninitialized, -Wsizeof-pointer-memaccess , -Wdangling-else, -Wheader-guard, -Wenum-conversion, -Winvalid-source-encoding" compile warnings under osx.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xunzhang/incubator-hawq HAWQ-1187
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1035.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1035
----
commit ed223548164b5a5a7bedb48f759eb51451373c0a
Author: xunzhang <xu...@gmail.com>
Date: 2016-12-02T16:02:35Z
HAWQ-1187. Fix "-Wsometimes-uninitialized, -Wsizeof-pointer-memaccess, -Wdangling-else, -Wheader-guard, -Wenum-conversion, -Winvalid-source-encoding" compile warnings under osx.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1035#discussion_r90799626
--- Diff: src/bin/pg_dump/dumputils.c ---
@@ -1062,7 +1062,7 @@ char *
custom_fmtopts_string(const char *src)
{
int len = src ? strlen(src) : 0;
- char *result = malloc(len * 2 + 1);
+ char *result = calloc(1, len * 2 + 1);
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1035#discussion_r90798741
--- Diff: src/bin/pg_dump/dumputils.c ---
@@ -1062,7 +1062,7 @@ char *
custom_fmtopts_string(const char *src)
{
int len = src ? strlen(src) : 0;
- char *result = malloc(len * 2 + 1);
+ char *result = calloc(1, len * 2 + 1);
--- End diff --
I think this is a weird usage, for the usage of calloc, the first parameter should be count, and the second should be size. What about call(len*2+1, sizeof(char)) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized, -Wsiz...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1035
also cc @stanlyxiang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized, -Wsiz...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1035
LGTM now. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized, -Wsiz...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1035
cc @paul-guo- @ictmalili
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized, -Wsiz...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1035
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized, -Wsiz...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1035
\uff0b1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized, -Wsiz...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1035
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1035
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---