Re: [VOTE] Release Apache Commons VFS Distribution 2.3 based on RC1

[Gary Gregory <ga...@gmail.com>]

On Sun, Jan 27, 2019 at 11:08 PM Bruno P. Kinoshita
<br...@yahoo.com.br.invalid> wrote:

> Hmm, couldn't build it. Tried from the dist archive, decompressing the
> .tar.gz source.
>
> I think the test failing in my case is not listed in your notes about
> known failures?(used mvn clean install -e -X)
>
> Results :
>
> Tests in error:
>   GetContentInfoFunctionalTest.testGetContentInfo:72 » IllegalState
> Connection f...
>

This is a bug in the test setup I'm pretty sure: The WebDAV tests shutdowns
the HttpClient connection pool and other tests do not make sure they start
with a clean slate. I can't explain why this only shows up on Linux and not
Windows or macOS. I am canceling this VOTE to fix the tests and other nits.
RC2 will be coming soon.

Gary

>
> Tests run: 2613, Failures: 0, Errors: 1, Skipped: 4
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Commons VFS Project 2.3 ..................... SUCCESS [
> 3.720 s]
> [INFO] Apache Commons VFS ................................. FAILURE [06:18
> min]
> [INFO] Apache Commons VFS Examples ........................ SKIPPED
> [INFO] Apache Commons VFS Distribution 2.3 ................ SKIPPED
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 06:22 min
> [INFO] Finished at: 2019-01-28T17:01:46+13:00
> [INFO]
> ------------------------------------------------------------------------
>
> More info:
>
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.006 sec
> <<< FAILURE! - in
> org.apache.commons.vfs2.provider.https.test.GetContentInfoFunctionalTest
> testGetContentInfo(org.apache.commons.vfs2.provider.https.test.GetContentInfoFunctionalTest)
> Time elapsed: 0.006 sec  <<< ERROR!
> java.lang.IllegalStateException: Connection factory has been shutdown.
>     at
> org.apache.commons.httpclient.MultiThreadedHttpConnectionManager.doGetConnection(MultiThreadedHttpConnectionManager.java:463)
>     at
> org.apache.commons.httpclient.MultiThreadedHttpConnectionManager.getConnectionWithTimeout(MultiThreadedHttpConnectionManager.java:416)
>     at
> org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:153)
>     at
> org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397)
>     at
> org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323)
>
>
> Environment:
>
> $ mvn -v
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-18T06:33:14+12:00)
> Maven home: /opt/apache-maven-3.5.4
> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_NZ, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-43-generic", arch: "amd64", family:
> "unix"
>
>
> Could it be something with my environment?
>
>
> Could you give a bit of background why there are some tests that are
> failing but will be fixed only later, please? Should it be in the release
> notes too? Just so in case anybody ever needs to re-build it, s/he will
> know that those failures are expected?
>
> Cheers
> Bruno
>
>
>
>
> On Monday, 28 January 2019, 4:29:07 AM NZDT, Gary Gregory <
> ggregory@apache.org> wrote:
>
>
>
>
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons VFS Distribution 2.2 was released, so I would like to
> release Apache Commons VFS Distribution 2.3.
>
> Apache Commons VFS Distribution 2.3 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1 (svn
> revision 32156)
>
> The Subversion tag for this RC is here:
>
>
> http://svn.apache.org/repos/asf/commons/proper/vfs/tags/commons-vfs2-project-2.3-rc1/
> (svn revision 1852298)
>     N.B. the SVN revision is required because SVN tags are not immutable.
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1416
>
> These are the Maven artifacts and their hashes in Nexus:
>
> #Release SHA-512s
> #Sun Jan 27 09:38:10 EST 2019
>
> commons-vfs2-distribution-2.3-src-zip.asc=8f7d574cc0ffd0ffc22eefe95221b35aebfd16002934b35266c4be1978b7a0599ab68d3af64c20fe280a644f23adec2579d3fdc847edf3f243514788907614d8
>
> commons-vfs2-distribution-2.3-pom.asc=59610c8a7df4bbde92276074ae8ac837cc4bb7210f96322391843601e30046b83111df7b3fc8cc28de275d313ad8f9ea4d6377cdefdd6486c106b526a89703b1
>
> commons-vfs2-distribution-2.3-bin-zip=baf9f9a80cf8d3948acd970ec174d03757e50b64988f1a9367c88fc15bf0c9e22e1989c6a61c95395e30eef19caaa4281efdc6290d3baf8a1710a346d3b4e9ff
>
> commons-vfs2-distribution-2.3-bin-tar.gz=b5c71f6b42c8a67a14caf33bafecb0fa159f22cc4bc33cb9d67710ad87a3fb7f5917c6740ece414ab3a6f933085644826c3706e75c4bead017a2812d3a288107
>
> commons-vfs2-distribution-2.3-bin-tar.gz.asc=ddc2f7c8b5109cbf5b3c2170bf46c0921a57b38d8e13a162de21f6fc74813d7099c8da313e7640ed7936f7941044ef9a5b04fb7e88279bb9be4c9fcf37633959
>
> commons-vfs2-distribution-2.3-src-zip=8226e2e8bfe41e744569c6f5cbb2bfb890b203e9d935822b4d8a77520837c160200d867b4e871bdef7d9e89d032fcc4c3f30f0677ceb29c18f5ed86b1b2469e7
>
> commons-vfs2-distribution-2.3-bin-zip.asc=e76131162a6e4632e070b4b6b463f3f10ca54216e1a81b4b04f13f07b5af381eb1f4a10707b64c2fe8305d21fa7213fc2009b7bd7746e5daee55477714bd7830
>
> commons-vfs2-distribution-2.3-src-tar.gz=0d68b7b05a5a5a01fac41ef97fbf8d2ab343b1b1a48a3428237078e8a4d06a6f3996f0ed310dbd409f2c29b67c238e3451f01829f2ed5cceeae905ebc88af3c8
>
> commons-vfs2-distribution-2.3-src-tar.gz.asc=771ac16522ed22748a342ed3ea6a2981b4082f1d6f773ce032e03d7409d771c2eeb01eb11ab4f61aee8eb2103e3e5d7bf21599a60fea76bb816db4c48308cc24
>
> (no need for .asc hashes!)
>
> I have tested this with 'mvn clean install site' using:
>
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
> 2018-10-24T14:41:47-04:00)
> Maven home: C:\Java\apache-maven-3.6.0\bin\..
> Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_202\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> and then 'mvn test' using:
>
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
> 2018-10-24T14:41:47-04:00)
> Maven home: C:\Java\apache-maven-3.6.0\bin\..
> Java version: 11.0.2, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk-11.0.2
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Which yields some test failures to be dealt with in a later release.
>
> Tests in error:
>
>
> AbstractFtpsProviderTestCase$FtpProviderTestSuite>AbstractTestSuite.run:137->setUp:153->AbstractTestSuite.setUp:166
> » FileSystem
>
>
> AbstractFtpsProviderTestCase$FtpProviderTestSuite>AbstractTestSuite.run:137->setUp:153->AbstractTestSuite.setUp:166
> » FileSystem
>   MultipleConnectionTestCase.testConnectRoot:55->resolveRoot:49 »
> FileSystem Cou...
>   MultipleConnectionTestCase.testUnderlyingConnect:65 » SSL Unsupported or
> unrec...
>
> Details of changes since 2.2 are in the release notes:
>
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1/RELEASE-NOTES.txt
>
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1/site/changes-report.html
>
> Site:
>     https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1/site
>     (note some *relative* links are broken and the 2.3 directories are not
> yet created - these will be OK once the site is deployed.)
>
> CLIRR Report (compared to 2.2): 'mvn clirr:check' is OK but no report was
> generated.
> The Clirr check should have failed because Clirr does not know about Java 8
> default methods, specifically the addition of the default method
> org.apache.commons.vfs2.provider.ftp.FtpClient.getReplyString().
> That said there is no API breakage in 2.3.
>
> JApiCmp Report (compared to 2.2) is empty due to some funkiness in
> commons-parent.
>
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1/site/japicmp.html
>
> RAT Report:
>
>
> https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>