You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "dragon-zhang (via GitHub)" <gi...@apache.org> on 2023/02/14 14:57:12 UTC

[GitHub] [shenyu] dragon-zhang opened a new pull request, #4386: [type: performance] optimize UpstreamCheckService

dragon-zhang opened a new pull request, #4386:
URL: https://github.com/apache/shenyu/pull/4386

   <!-- Describe your PR here; eg. Fixes #issueNo -->
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shenyu] codecov-commenter commented on pull request #4386: [type: performance] optimize UpstreamCheckService

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4386:
URL: https://github.com/apache/shenyu/pull/4386#issuecomment-1429915227

   # [Codecov](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4386](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff0eb2b) into [master](https://codecov.io/gh/apache/shenyu/commit/ff7e9809f30c2f638a3b7f3bcd290ac567f1e1b8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff7e980) will **decrease** coverage by `0.08%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4386      +/-   ##
   ============================================
   - Coverage     68.38%   68.30%   -0.08%     
   + Complexity     7516     7511       -5     
   ============================================
     Files          1020     1020              
     Lines         28813    28813              
     Branches       2568     2565       -3     
   ============================================
   - Hits          19704    19681      -23     
   - Misses         7575     7592      +17     
   - Partials       1534     1540       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `66.09% <100.00%> (-0.58%)` | :arrow_down: |
   | [...henyu/common/cache/MemorySafeWindowTinyLFUMap.java](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jYWNoZS9NZW1vcnlTYWZlV2luZG93VGlueUxGVU1hcC5qYXZh) | `73.33% <0.00%> (-8.34%)` | :arrow_down: |
   | [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `21.27% <0.00%> (-6.39%)` | :arrow_down: |
   | [...rg/apache/shenyu/plugin/rewrite/RewritePlugin.java](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmV3cml0ZS9SZXdyaXRlUGx1Z2luLmphdmE=) | `66.66% <0.00%> (-5.56%)` | :arrow_down: |
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `58.51% <0.00%> (-5.32%)` | :arrow_down: |
   | [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `85.71% <0.00%> (-4.09%)` | :arrow_down: |
   | [...in/response/strategy/NettyClientMessageWriter.java](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc3BvbnNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3Jlc3BvbnNlL3N0cmF0ZWd5L05ldHR5Q2xpZW50TWVzc2FnZVdyaXRlci5qYXZh) | `71.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [...a/org/apache/shenyu/plugin/mock/util/MockUtil.java](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbW9jay91dGlsL01vY2tVdGlsLmphdmE=) | `77.55% <0.00%> (-2.05%)` | :arrow_down: |
   | [...yu/admin/service/impl/PluginHandleServiceImpl.java](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1BsdWdpbkhhbmRsZVNlcnZpY2VJbXBsLmphdmE=) | `74.07% <0.00%> (-1.86%)` | :arrow_down: |
   | [...client/brpc/BrpcContextRefreshedEventListener.java](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWJycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvYnJwYy9CcnBjQ29udGV4dFJlZnJlc2hlZEV2ZW50TGlzdGVuZXIuamF2YQ==) | `68.57% <0.00%> (-1.43%)` | :arrow_down: |
   | ... and [1 more](https://codecov.io/gh/apache/shenyu/pull/4386?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shenyu] KevinClair merged pull request #4386: [type: performance] optimize UpstreamCheckService

Posted by "KevinClair (via GitHub)" <gi...@apache.org>.
KevinClair merged PR #4386:
URL: https://github.com/apache/shenyu/pull/4386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org