You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Kikyou1997 (via GitHub)" <gi...@apache.org> on 2023/07/10 07:04:59 UTC

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #21482: [enhancement](nereids) Sync stats across FE cluster after analyze

Kikyou1997 commented on code in PR #21482:
URL: https://github.com/apache/doris/pull/21482#discussion_r1257812079


##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java:
##########
@@ -138,7 +175,8 @@ public static ColumnStatistic fromResultRow(ResultRow resultRow) {
             columnStatisticBuilder.setNumNulls(Double.parseDouble(nullCount));
             columnStatisticBuilder.setDataSize(Double
                     .parseDouble(resultRow.getColumnValueWithDefault("data_size_in_bytes", "0")));
-            columnStatisticBuilder.setAvgSizeByte(columnStatisticBuilder.getDataSize()
+            columnStatisticBuilder.setAvgSizeByte(columnStatisticBuilder.getCount() == 0 ?

Review Comment:
   这不这么处理,这个地方就是NaN,现在Gson处理不了NaN,序列化会失败。你觉得不合适的原因是什么



##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java:
##########
@@ -138,7 +175,8 @@ public static ColumnStatistic fromResultRow(ResultRow resultRow) {
             columnStatisticBuilder.setNumNulls(Double.parseDouble(nullCount));
             columnStatisticBuilder.setDataSize(Double
                     .parseDouble(resultRow.getColumnValueWithDefault("data_size_in_bytes", "0")));
-            columnStatisticBuilder.setAvgSizeByte(columnStatisticBuilder.getDataSize()
+            columnStatisticBuilder.setAvgSizeByte(columnStatisticBuilder.getCount() == 0 ?

Review Comment:
   这不这么处理,这个地方就是NaN,现在Gson处理不了NaN,序列化会失败。你觉得不合适的原因是什么



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org