You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/04/23 23:54:02 UTC
[GitHub] [httpcomponents-client] varunnvs92 opened a new pull request #146:
Fix bug in URIBuilder#isPathEmpty method
varunnvs92 opened a new pull request #146: Fix bug in URIBuilder#isPathEmpty method
URL: https://github.com/apache/httpcomponents-client/pull/146
isPathEmpty should verify if encodedPath member is an empty string.
Otherwise, [this code](https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/client/utils/URIUtils.java#L229) in URIUtils.rewriteURI will evaluate to false when normalization is disabled.
Before 4.5.6, URIUtils.rewriteURI method used [TextUtils#isEmpty method](https://github.com/apache/httpcomponents-core/blob/master/httpcore5/src/main/java/org/apache/hc/core5/util/TextUtils.java#L42) which checked for both null and empty string case.
* Added a new unit test. The test failed before including the empty string check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org