You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/03/08 18:53:31 UTC

[GitHub] [maven-shared-utils] elharo opened a new pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell

elharo opened a new pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell
URL: https://github.com/apache/maven-shared-utils/pull/20
 
 
   @michael-o 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-shared-utils] michael-o commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell
URL: https://github.com/apache/maven-shared-utils/pull/20#discussion_r389411209
 
 

 ##########
 File path: src/main/java/org/apache/maven/shared/utils/cli/shell/CmdShell.java
 ##########
 @@ -24,7 +24,7 @@
 
 /**
  * <p>
- * Implementation to call the CMD Shell present on Windows NT, 2000 and XP
+ * Implementation to call the CMD Shell present on Windows NT, 2000, X, 7, and 10.
 
 Review comment:
   X => XP
   As well as Windows 8

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-shared-utils] elharo merged pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell

Posted by GitBox <gi...@apache.org>.
elharo merged pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell
URL: https://github.com/apache/maven-shared-utils/pull/20
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-shared-utils] elharo commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell

Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell
URL: https://github.com/apache/maven-shared-utils/pull/20#discussion_r389423292
 
 

 ##########
 File path: src/main/java/org/apache/maven/shared/utils/cli/shell/CmdShell.java
 ##########
 @@ -24,7 +24,7 @@
 
 /**
  * <p>
- * Implementation to call the CMD Shell present on Windows NT, 2000 and XP
+ * Implementation to call the CMD Shell present on Windows NT, 2000, X, 7, and 10.
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-shared-utils] elharo commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell

Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell
URL: https://github.com/apache/maven-shared-utils/pull/20#discussion_r389403374
 
 

 ##########
 File path: src/main/java/org/apache/maven/shared/utils/cli/shell/Shell.java
 ##########
 @@ -29,12 +29,11 @@
 /**
  * <p>
  * Class that abstracts the Shell functionality,
- * with subclases for shells that behave particularly, like
+ * with subclasses for shells that behave particularly, like</p>
 
 Review comment:
   fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-shared-utils] michael-o commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell
URL: https://github.com/apache/maven-shared-utils/pull/20#discussion_r389395981
 
 

 ##########
 File path: src/main/java/org/apache/maven/shared/utils/cli/shell/Shell.java
 ##########
 @@ -29,12 +29,11 @@
 /**
  * <p>
  * Class that abstracts the Shell functionality,
- * with subclases for shells that behave particularly, like
+ * with subclasses for shells that behave particularly, like</p>
 
 Review comment:
   Javadoc 8 will probably bug you for this. They expect `<p>` only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-shared-utils] elharo commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell

Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell
URL: https://github.com/apache/maven-shared-utils/pull/20#discussion_r389423360
 
 

 ##########
 File path: src/main/java/org/apache/maven/shared/utils/cli/shell/CommandShell.java
 ##########
 @@ -26,8 +26,9 @@
  * </p>
  *
  * @author <a href="mailto:carlos@apache.org">Carlos Sanchez</a>
- * 
+ * @deprecated Windows Me is long dead. Update to Windows 10 and use {@link CmdShell}.
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-shared-utils] michael-o commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #20: [MSHARED-860] deprecated Windows 9X CommandShell
URL: https://github.com/apache/maven-shared-utils/pull/20#discussion_r389411242
 
 

 ##########
 File path: src/main/java/org/apache/maven/shared/utils/cli/shell/CommandShell.java
 ##########
 @@ -26,8 +26,9 @@
  * </p>
  *
  * @author <a href="mailto:carlos@apache.org">Carlos Sanchez</a>
- * 
+ * @deprecated Windows Me is long dead. Update to Windows 10 and use {@link CmdShell}.
 
 Review comment:
   It was Windows ME. Horrible OS.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services