[GitHub] [airflow] potiuk commented on a diff in pull request #29694: Fixing log message + adding more verbose documetation

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #29694:
URL: https://github.com/apache/airflow/pull/29694#discussion_r1116764865


##########
airflow/providers/google/suite/hooks/drive.py:
##########
@@ -159,6 +160,46 @@ def exists(
             )
         )
 
+    def _resolve_file_path(self, file_id: str) -> str:
+        """
+        Returns the full Google Drive path for given file_id
+
+        :param file_id: The id of a file in Google Drive
+        :return: Google Drive full path for a file
+        """
+        MAX_NESTED_FOLDERS_LEVEL = 20

Review Comment:
   Wouod be great to link to the docs as comment here so that it's not seen to be as magical as it looks.



##########
airflow/providers/google/suite/hooks/drive.py:
##########
@@ -159,6 +160,46 @@ def exists(
             )
         )
 
+    def _resolve_file_path(self, file_id: str) -> str:
+        """
+        Returns the full Google Drive path for given file_id
+
+        :param file_id: The id of a file in Google Drive
+        :return: Google Drive full path for a file
+        """
+        MAX_NESTED_FOLDERS_LEVEL = 20

Review Comment:
   Would be great to link to the docs as comment here so that it's not seen to be as magical as it looks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org