[GitHub] [flink] zentol commented on a diff in pull request #19624: [FLINK-27476][test] build import option only focuses on maven main class files

[GitBox <gi...@apache.org>]

zentol commented on code in PR #19624:
URL: https://github.com/apache/flink/pull/19624#discussion_r863007167


##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/ImportOptions.java:
##########
@@ -57,4 +70,19 @@ public boolean includes(Location location) {
             return !location.matches(SHADED);
         }
     }
+
+    /** {@link Pattern} based predicate. */
+    private static class PatternPredicate implements Predicate<Location> {

Review Comment:
   this class seems unnecessary. Why not just do it like `ExcludeShadedImportOption`.



##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/ImportOptions.java:
##########
@@ -18,6 +18,8 @@
 
 package org.apache.flink.architecture.common;
 
+import org.apache.flink.shaded.guava30.com.google.common.base.Predicate;

Review Comment:
   why would you use guava for this when https://docs.oracle.com/javase/8/docs/api/java/util/function/Predicate.html exists? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org