[jira] [Commented] (HBASE-12478) HBASE-10141 and MIN_VERSIONS are not compatible

["Sergey Shelukhin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212931#comment-14212931 ] 

Sergey Shelukhin commented on HBASE-12478:
------------------------------------------

The patch just logs the message and doesn't skip anything.
Also, unit test would be nice, I think TestStore, TestCompaction or some such already tests this, so it should be easy to expand or c/p and modify

> HBASE-10141 and MIN_VERSIONS are not compatible
> -----------------------------------------------
>
>                 Key: HBASE-12478
>                 URL: https://issues.apache.org/jira/browse/HBASE-12478
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>             Fix For: 2.0.0, 0.98.9, 0.99.2
>
>         Attachments: 12478-v1.txt
>
>
> HBASE-10141 is a good optimization, eliminating the need to scan already expired files (through TTL). However, I think if MIN_VERSIONS is set, it will not ensure that there will be at least that many versions since it bypasses the scan layer. 
> I think we can just do a simple check before the HBASE-10141 optimization to see whether MIN_VERSIONS is set for the table, and if so just do the regular old way of doing the scan in the compaction. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)