You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2019/08/02 03:00:42 UTC
[kudu] branch master updated (5071386 -> bc80ccc)
This is an automated email from the ASF dual-hosted git repository.
adar pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git.
from 5071386 [quickstart] Fix a couple typos in the NiFi guide
new ff9d377 [docs] Remove the duplicate word
new d5eb683 [tablet] the row size is equal to schema size plus null bitmap size
new bc80ccc tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../java/org/apache/kudu/client/CreateTableOptions.java | 4 ++--
src/kudu/tablet/cfile_set-test.cc | 2 +-
src/kudu/tablet/tablet-test-util.h | 2 +-
src/kudu/tools/tool_action_table.cc | 14 +++++++-------
4 files changed, 11 insertions(+), 11 deletions(-)
[kudu] 03/03: tools: fix warning when compiling in ASAN and TSAN
caused by ConvertToKuduPartialRow.
Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
adar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit bc80ccc5b630cfa2c8d29889553780f0a1c7e5ef
Author: honeyhexin <ho...@sohu.com>
AuthorDate: Thu Aug 1 12:38:08 2019 +0800
tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
This is a follow-up to 58e01492320f954cd1 to fix warning in compile log
when build type is TSAN or ASAN.
Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
Reviewed-on: http://gerrit.cloudera.org:8080/13974
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
src/kudu/tools/tool_action_table.cc | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/kudu/tools/tool_action_table.cc b/src/kudu/tools/tool_action_table.cc
index 0abed54..f5cbed2 100644
--- a/src/kudu/tools/tool_action_table.cc
+++ b/src/kudu/tools/tool_action_table.cc
@@ -520,7 +520,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractInt64(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetInt8(col_name, static_cast<int8_t>(value));
+ RETURN_NOT_OK(range_bound_partial_row->SetInt8(col_name, static_cast<int8_t>(value)));
break;
}
case KuduColumnSchema::INT16: {
@@ -528,7 +528,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractInt64(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetInt16(col_name, static_cast<int16_t>(value));
+ RETURN_NOT_OK(range_bound_partial_row->SetInt16(col_name, static_cast<int16_t>(value)));
break;
}
case KuduColumnSchema::INT32: {
@@ -536,7 +536,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractInt32(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetInt32(col_name, value);
+ RETURN_NOT_OK(range_bound_partial_row->SetInt32(col_name, value));
break;
}
case KuduColumnSchema::INT64: {
@@ -544,7 +544,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractInt64(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetInt64(col_name, value);
+ RETURN_NOT_OK(range_bound_partial_row->SetInt64(col_name, value));
break;
}
case KuduColumnSchema::UNIXTIME_MICROS: {
@@ -552,7 +552,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractInt64(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetUnixTimeMicros(col_name, value);
+ RETURN_NOT_OK(range_bound_partial_row->SetUnixTimeMicros(col_name, value));
break;
}
case KuduColumnSchema::BINARY: {
@@ -560,7 +560,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractString(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetBinary(col_name, value);
+ RETURN_NOT_OK(range_bound_partial_row->SetBinary(col_name, value));
break;
}
case KuduColumnSchema::STRING: {
@@ -568,7 +568,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractString(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetString(col_name, value);
+ RETURN_NOT_OK(range_bound_partial_row->SetString(col_name, value));
break;
}
case KuduColumnSchema::BOOL:
[kudu] 02/03: [tablet] the row size is equal to schema size plus
null bitmap size
Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
adar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit d5eb6832704fc11a624e5d02a5910dc96245ca3c
Author: helifu <hz...@corp.netease.com>
AuthorDate: Fri Aug 2 08:58:10 2019 +0800
[tablet] the row size is equal to schema size plus null bitmap size
The DCHECK_EQ statement in debug mode is not true while there are
nullable columns in schema.
Change-Id: Id26650c58f5c8f32a233901605f3c4543b05f3b3
Reviewed-on: http://gerrit.cloudera.org:8080/13985
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
src/kudu/tablet/cfile_set-test.cc | 2 +-
src/kudu/tablet/tablet-test-util.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/kudu/tablet/cfile_set-test.cc b/src/kudu/tablet/cfile_set-test.cc
index 33f21d3..e3fd517 100644
--- a/src/kudu/tablet/cfile_set-test.cc
+++ b/src/kudu/tablet/cfile_set-test.cc
@@ -73,7 +73,7 @@ class TestCFileSet : public KuduRowSetTest {
TestCFileSet() :
KuduRowSetTest(Schema({ ColumnSchema("c0", INT32),
ColumnSchema("c1", INT32, false, nullptr, nullptr, GetRLEStorage()),
- ColumnSchema("c2", INT32) }, 1))
+ ColumnSchema("c2", INT32, true) }, 1))
{}
virtual void SetUp() OVERRIDE {
diff --git a/src/kudu/tablet/tablet-test-util.h b/src/kudu/tablet/tablet-test-util.h
index 599f113..3215254 100644
--- a/src/kudu/tablet/tablet-test-util.h
+++ b/src/kudu/tablet/tablet-test-util.h
@@ -333,7 +333,7 @@ static inline Status DumpTablet(const Tablet& tablet,
template<class RowSetWriterClass>
static Status WriteRow(const Slice &row_slice, RowSetWriterClass *writer) {
const Schema &schema = writer->schema();
- DCHECK_EQ(row_slice.size(), schema.byte_size());
+ DCHECK_EQ(row_slice.size(), schema.byte_size() + ContiguousRowHelper::null_bitmap_size(schema));
RowBlock block(&schema, 1, nullptr);
ConstContiguousRow row(&schema, row_slice.data());
[kudu] 01/03: [docs] Remove the duplicate word
Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
adar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit ff9d377c04374999514aa48e8b3470126893fc30
Author: oclarms <oc...@gmail.com>
AuthorDate: Thu Aug 1 19:01:22 2019 +0800
[docs] Remove the duplicate word
Change-Id: Ie988c1e7e635449c4ff5ca40170d628b9b3a1a8e
Reviewed-on: http://gerrit.cloudera.org:8080/13977
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
.../src/main/java/org/apache/kudu/client/CreateTableOptions.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java b/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
index 9372ad9..630d73e 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
@@ -113,8 +113,8 @@ public class CreateTableOptions {
}
/**
- * Add a range partition partition to the table with an inclusive lower bound
- * and an exclusive upper bound.
+ * Add a range partition to the table with an inclusive lower bound and an
+ * exclusive upper bound.
*
* If either row is empty, then that end of the range will be unbounded. If a
* range column is missing a value, the logical minimum value for that column