You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2019/11/19 08:05:00 UTC

[jira] [Commented] (CALCITE-3514) LatticeTest fails when JdbcSchema re-computes JdbcTables

    [ https://issues.apache.org/jira/browse/CALCITE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977225#comment-16977225 ] 

Stamatis Zampetakis commented on CALCITE-3514:
----------------------------------------------

Thanks for raising this [~donnyzone]! Should the test rely on tables equality in the first place? 

> LatticeTest fails when JdbcSchema re-computes JdbcTables
> --------------------------------------------------------
>
>                 Key: CALCITE-3514
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3514
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.21.0
>            Reporter: Feng Zhu
>            Assignee: Feng Zhu
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
>     In our production environment, we find that when we disable the cache for _JdbcTable_ in *_JdbcSchema_*, some tests (e.g., _testTwoLattices, testTileAlgorithm2_) in LatticeTest will fail.
>   The problem can be reproduced by rewriting the _getTable_ method in JdbcSchema, i.e., setting _force=true_.
> {code:java}
> public Table getTable(String name) {
>   return getTableMap(true).get(name);
> }{code}
> We need to implement JdbcTable's _equals()_ and _hashCode()_ methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)