You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Michael Becke <be...@u.washington.edu> on 2003/03/07 03:40:59 UTC

patch comments

Are there any comment for or against the following patches?

the patch attached to:
	http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17563

and:

Begin forwarded message:

> From: Michael Becke <be...@u.washington.edu>
> Date: Sat Mar 1, 2003  12:36:02 PM US/Eastern
> To: Commons Project <co...@jakarta.apache.org>
> Subject: [PATCH] SSL Tunneling Connection Timeout
>
> As discussed in the IRC session on Thursday here is a patch that 
> should "fix" the timeout problem that occurs when using Https through 
> a proxy.  This fixes the problem by not allowing HttpConnections that 
> are tunneled to be reused.  This is by no means a perfect solution but 
> it should add some stability.  There is still a potential problem in 
> HttpMethodBase.processRequest() when a retry occurs.  In this case the 
> connection will be reopen but without the necessary step of creating 
> the proxy tunnel.  One option here would be to set maxRetriesto 0.  
> Please take a look and let me know.
>
> Thanks,
>
> Mike
>

Re: patch comments

Posted by Jeffrey Dever <js...@sympatico.ca>.
go4it

Michael Becke wrote:

> Are there any comment for or against the following patches?
>
> the patch attached to:
>     http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17563
>
> and:
>
> Begin forwarded message:
>
>> From: Michael Becke <be...@u.washington.edu>
>> Date: Sat Mar 1, 2003  12:36:02 PM US/Eastern
>> To: Commons Project <co...@jakarta.apache.org>
>> Subject: [PATCH] SSL Tunneling Connection Timeout
>>
>> As discussed in the IRC session on Thursday here is a patch that 
>> should "fix" the timeout problem that occurs when using Https through 
>> a proxy.  This fixes the problem by not allowing HttpConnections that 
>> are tunneled to be reused.  This is by no means a perfect solution 
>> but it should add some stability.  There is still a potential problem 
>> in HttpMethodBase.processRequest() when a retry occurs.  In this case 
>> the connection will be reopen but without the necessary step of 
>> creating the proxy tunnel.  One option here would be to set 
>> maxRetriesPlease take a look and let me know.
>>
>> Thanks,
>>
>> Mike
>>
>
>
>------------------------------------------------------------------------
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org
>