You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/04 00:19:00 UTC
[jira] [Work logged] (BEAM-4000) Futurize and fix python 2
compatibility for io subpackage
[ https://issues.apache.org/jira/browse/BEAM-4000?focusedWorklogId=131152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131152 ]
ASF GitHub Bot logged work on BEAM-4000:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/18 00:18
Start Date: 04/Aug/18 00:18
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5715: [BEAM-4000] Futurize io subpackage
URL: https://github.com/apache/beam/pull/5715#discussion_r207692947
##########
File path: sdks/python/apache_beam/io/gcp/pubsub.py
##########
@@ -33,8 +33,9 @@
from __future__ import absolute_import
import re
+from builtins import object
-from six import text_type
+from past.builtins import basestring
Review comment:
@Fematich
Do you remember, why did we decide to use `past.builtins.basestring` here instead of `past.builtins.unicode`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 131152)
Time Spent: 6h 10m (was: 6h)
> Futurize and fix python 2 compatibility for io subpackage
> ---------------------------------------------------------
>
> Key: BEAM-4000
> URL: https://issues.apache.org/jira/browse/BEAM-4000
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)