You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Yilialinn (via GitHub)" <gi...@apache.org> on 2026/04/21 12:11:37 UTC
[PR] docs: fix opentelemetry plugin documentation [apisix]
Yilialinn opened a new pull request, #13276:
URL: https://github.com/apache/apisix/pull/13276
## Summary
- Fix typo `OLTP` → `OTLP` (OTLP = OpenTelemetry Protocol) in EN and ZH frontmatter description and body text
- Fix `$admin_key` → `${admin_key}` in curl commands (EN and ZH)
- Add missing introductory sentence before the access log example code block in ZH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: fix opentelemetry plugin documentation [apisix]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13276:
URL: https://github.com/apache/apisix/pull/13276#discussion_r3122018259
##########
docs/en/latest/plugins/opentelemetry.md:
##########
@@ -300,7 +300,7 @@ The following example demonstrates how to configure the `opentelemetry` Plugin t
Configure the plugin metadata to set `set_ngx_var` as true:
```shell
-curl http://127.0.0.1:9180/apisix/admin/plugin_metadata/opentelemetry -H "X-API-KEY: $admin_key" -X PUT -d '
+curl http://127.0.0.1:9180/apisix/admin/plugin_metadata/opentelemetry -H "X-API-KEY: ${admin_key}" -X PUT -d '
{
Review Comment:
The PR description says curl commands were updated from `$admin_key` to `${admin_key}` in the EN docs, but this file still has an earlier curl example using `$admin_key` (see line 55). This leaves inconsistent syntax within the same doc and suggests the change is incomplete; either update the earlier command too or adjust the PR description scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: fix opentelemetry plugin documentation [apisix]
Posted by "Yilialinn (via GitHub)" <gi...@apache.org>.
Yilialinn merged PR #13276:
URL: https://github.com/apache/apisix/pull/13276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org