[GitHub] [tvm] mshawcroft commented on a change in pull request #9682: [CMSIS-NN] Fixed return data type from pattern callback function

[GitBox <gi...@apache.org>]

mshawcroft commented on a change in pull request #9682:
URL: https://github.com/apache/tvm/pull/9682#discussion_r765031797



##########
File path: python/tvm/relay/op/contrib/cmsisnn.py
##########
@@ -227,7 +227,7 @@ def binary_op_pattern(op):
 
     def check_qnn_binary_op(extract):
         """Check if multiply is supported by CMSIS-NN."""
-        return (
+        return bool(

Review comment:
       Im puzzled by this change.  Specifically I don't understand how the insertion of the bool() cast here changes the return type of the function, superficially it looks like the two subclauses are comparisons of str == str, both resulting in a class 'bool', applying 'and' to two bools will result in a bool.   So what does the cast achieve?
   
   Ditto the same logic applies to each of the previous bool casts inserted above...
   
   What am I missing?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org