[GitHub] [hbase] wchevreuil commented on a change in pull request #1953: HBASE-21773 - Addendum - Bring back "public static Job createSubmitta…

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #1953:
URL: https://github.com/apache/hbase/pull/1953#discussion_r444071481



##########
File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java
##########
@@ -137,6 +137,103 @@ public Job createSubmittableJob(Configuration conf) throws IOException {
     return job;
   }
 
+  /**
+   * Sets up the actual job.
+   *
+   * @param conf  The current configuration.
+   * @param args  The command line parameters.
+   * @return The newly created job.
+   * @throws IOException When setting up the job fails.
+   * @deprecated please use main method instead.

Review comment:
       So @ndimiduk  we cannot remove it in release `3.0.0`, only on `4.0.0`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org