You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Kevan Miller (JIRA)" <ji...@apache.org> on 2007/04/16 20:16:15 UTC

[jira] Resolved: (GERONIMO-3017) Web Apps (WAR files) that directly contain JPA entities cannot be deployed

     [ https://issues.apache.org/jira/browse/GERONIMO-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevan Miller resolved GERONIMO-3017.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0-M5

Applied patch. Thanks Jay!

I didn't do anything with your patch program, since you didn't click the grant asf license button.

> Web Apps (WAR files) that directly contain JPA entities cannot be deployed
> --------------------------------------------------------------------------
>
>                 Key: GERONIMO-3017
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3017
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: persistence
>    Affects Versions: 2.0-M5
>            Reporter: Jay D. McHugh
>         Assigned To: Kevan Miller
>             Fix For: 2.0-M5
>
>         Attachments: geronimo-3017-2.patch, geronimo-jira-3017.patch, jpa-war-src-2.tar.bz2, jpa-war-src.tar.bz2, jpa-war.war
>
>
> There is still a find and parse problem with persistence.xml in war files.
> It seems to work if you have your jpa entities in a jar file.
> But, if you have a WEB-INF/lib/META-INF/persistence.xml file, it finds it and dies with a substring error.
> I have not tested to see if this is a problem for WAR files contained in an EAR.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Resolved: (GERONIMO-3017) Web Apps (WAR files) that directly contain JPA entities cannot be deployed

Posted by Kevan Miller <ke...@gmail.com>.
On Apr 17, 2007, at 2:19 AM, Jacek Laskowski wrote:

> On 4/16/07, Kevan Miller (JIRA) <ji...@apache.org> wrote:
>>
>>      [ https://issues.apache.org/jira/browse/GERONIMO-3017? 
>> page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Kevan Miller resolved GERONIMO-3017.
>> ------------------------------------
>>
>>        Resolution: Fixed
>>     Fix Version/s: 2.0-M5
>>
>> Applied patch. Thanks Jay!
>>
>> I didn't do anything with your patch program, since you didn't  
>> click the grant asf license button.
>
> That struck me. How could we apply this patch then? It's our codebase
> now so anybody can modify it now and has not been able before? I think
> we need to revert the change and ask Jay for the license to include
> it. Only afterwards are we allowed to apply the patch, aren't we?
>
> I've seen Jay licensed the code to us so I wonder whether we shouldn't
> re-apply it with the former commit reverted?

Jacek,
There were two parts to that Jira. A code patch and a test program.  
Jay did grant the ASF license to his 'patch'. He didn't grant the ASF  
license to his test program.

I only applied the patch. I used, but did not apply his test program.  
So, I don't see any issues...

--kevan

Re: [jira] Resolved: (GERONIMO-3017) Web Apps (WAR files) that directly contain JPA entities cannot be deployed

Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 4/16/07, Kevan Miller (JIRA) <ji...@apache.org> wrote:
>
>      [ https://issues.apache.org/jira/browse/GERONIMO-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Kevan Miller resolved GERONIMO-3017.
> ------------------------------------
>
>        Resolution: Fixed
>     Fix Version/s: 2.0-M5
>
> Applied patch. Thanks Jay!
>
> I didn't do anything with your patch program, since you didn't click the grant asf license button.

That struck me. How could we apply this patch then? It's our codebase
now so anybody can modify it now and has not been able before? I think
we need to revert the change and ask Jay for the license to include
it. Only afterwards are we allowed to apply the patch, aren't we?

I've seen Jay licensed the code to us so I wonder whether we shouldn't
re-apply it with the former commit reverted?

Jacek

-- 
Jacek Laskowski
http://www.JacekLaskowski.pl