[GitHub] [commons-fileupload] jochenw commented on issue #22: Adding capability to take max upload size per request.Fileupload 1 3 1

[GitBox <gi...@apache.org>]

jochenw commented on issue #22: Adding capability to take max upload size per request.Fileupload 1 3 1
URL: https://github.com/apache/commons-fileupload/pull/22#issuecomment-533821094
 
 
   1. I'd support Gary's request, that you provide a PR for the current master, and not the stable branch.
   2. Well spotted, that you should use the RequestContext, to support both the servlet, and the portlet case!
   3. Rather than using a method getSizeMaxForThisRequest, I'd suggest a more general approach, (The 1.4 branch is still open for API changes.) such as:
   
       - Replace 
   
   > FileItemStream FileUploadBase.getItemIterator(RequestContext pCtx)
   
    with a method 
   
   > FileItemRequest getItemIterator(RequestContext pCtx)
   
   where FileItemRequest would contain methods like
   
       void setMaxUploadSizeExceeded(Predicate<Long> pPredicate) {
       }
       FileItemStream getItemIterator();
   
   On the other hand, rethinking that, it is probably a better idea, if I do that myself.
   
   
   > 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services