You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Afkham Azeez <af...@gmail.com> on 2007/05/28 15:14:38 UTC
[Axis2] Removing ContextListener
The ContextListener interface is not used by the clustering implementation.
We directly call ContextManager.addContext() from the relevant places.
Is this interface intended for any other purpose? Shall we remove it?
--
Thanks
Afkham Azeez
http://www.wso2.org
GPG Fingerprint: 643F C2AF EB78 F886 40C9 B2A2 4AE2 C887 665E 0760
Re: [Axis2] Removing ContextListener
Posted by Chamikara Jayalath <ch...@gmail.com>.
+1
Chamikara
On 5/29/07, Deepal Jayasinghe <de...@opensource.lk> wrote:
>
>
>
> Afkham Azeez wrote:
> > The ContextListener interface is not used by the clustering
> > implementation. We directly call ContextManager.addContext() from the
> > relevant places.
> > Is this interface intended for any other purpose? Shall we remove it?
> >
> +1 to remove that , if no one is using that.
>
> Thanks
> Deepal
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>
--
Chamikara Jayalath
WSO2 Inc.
http://wso2.com/
http://wso2.org/ - For your Oxygen needs
Re: [Axis2] Removing ContextListener
Posted by Deepal Jayasinghe <de...@opensource.lk>.
Afkham Azeez wrote:
> The ContextListener interface is not used by the clustering
> implementation. We directly call ContextManager.addContext() from the
> relevant places.
> Is this interface intended for any other purpose? Shall we remove it?
>
+1 to remove that , if no one is using that.
Thanks
Deepal
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [Axis2] Removing ContextListener
Posted by Chamikara Jayalath <ch...@gmail.com>.
Oh, sorry Glen I misunderstood what Azeez said. My +1 for removing the
ContextManagerListener of Clustering not the ContextListener of Axis2. As
you have mentioned having this ContextListeners will help us to cleanly
capture context events of Axis2. So I think our clustering impl should use
that.
Chamikara
On 5/29/07, Glen Daniels <gl...@thoughtcraft.com> wrote:
>
> Hi Afkham!
>
> Afkham Azeez wrote:
> > Hi Glen,
> > When I checked the logs, I found that you have introduced this
> > interface. What is the usage of this interface?
>
> This was added because we refactored ContextFactory away - and the
> reason for ContextFactory was to have one place that we could be
> notified of all the *Context creations (even though it never actually
> did that!).
>
> See thread at http://marc.info/?l=axis-dev&m=117822877408932&w=2.
> Apparently no one integrated this into the actual clustering code.
>
> > In the clustering implementation, we need to track the add context &
> > remove context events for service group contexts & service contexts.
> > Currently we are directly calling cluster manager from the relevant
> > places. Can this interface be adopted by the clustering implementation?
>
> Well, that was the idea... :)
>
> Do whatever the right thing is. If you feel you're getting good mileage
> out of the current code and there isn't too much tight coupling, feel
> free to remove ContextListener and associated APIs. Otherwise feel free
> to utilize it.
>
> Thanks,
> --Glen
>
> > On 5/28/07, *Afkham Azeez* <afkham@gmail.com <ma...@gmail.com>>
> > wrote:
> >
> > The ContextListener interface is not used by the clustering
> > implementation. We directly call ContextManager.addContext() from
> > the relevant places.
> > Is this interface intended for any other purpose? Shall we remove
> it?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>
--
Chamikara Jayalath
WSO2 Inc.
http://wso2.com/
http://wso2.org/ - For your Oxygen needs
Re: [Axis2] Removing ContextListener
Posted by Afkham Azeez <af...@gmail.com>.
I'm removing this interface and the related code since, in our clustering
implementation, we are not going to send messages when contexts are added
anymore.
-- Azeez
On 5/29/07, Afkham Azeez <af...@gmail.com> wrote:
>
> Hi Glen,
> OK got it. I'll integrate this once I finish what I'm working on right
> now.
>
> Thanks
> Azeez
>
> On 5/29/07, Glen Daniels < glen@thoughtcraft.com> wrote:
> >
> > Hi Afkham!
> >
> > Afkham Azeez wrote:
> > > Hi Glen,
> > > When I checked the logs, I found that you have introduced this
> > > interface. What is the usage of this interface?
> >
> > This was added because we refactored ContextFactory away - and the
> > reason for ContextFactory was to have one place that we could be
> > notified of all the *Context creations (even though it never actually
> > did that!).
> >
> > See thread at http://marc.info/?l=axis-dev&m=117822877408932&w=2 .
> > Apparently no one integrated this into the actual clustering code.
> >
> > > In the clustering implementation, we need to track the add context &
> > > remove context events for service group contexts & service contexts.
> > > Currently we are directly calling cluster manager from the relevant
> > > places. Can this interface be adopted by the clustering
> > implementation?
> >
> > Well, that was the idea... :)
> >
> > Do whatever the right thing is. If you feel you're getting good mileage
> >
> > out of the current code and there isn't too much tight coupling, feel
> > free to remove ContextListener and associated APIs. Otherwise feel free
> > to utilize it.
> >
> > Thanks,
> > --Glen
> >
> > > On 5/28/07, *Afkham Azeez* < afkham@gmail.com <mailto:afkham@gmail.com
> > >>
> > > wrote:
> > >
> > > The ContextListener interface is not used by the clustering
> > > implementation. We directly call ContextManager.addContext() from
> > > the relevant places.
> > > Is this interface intended for any other purpose? Shall we remove
> > it?
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-dev-help@ws.apache.org
> >
> >
>
>
> --
> Thanks
> Afkham Azeez
>
> http://www.wso2.org
> GPG Fingerprint: 643F C2AF EB78 F886 40C9 B2A2 4AE2 C887 665E 0760
>
--
Thanks
Afkham Azeez
http://www.wso2.org
GPG Fingerprint: 643F C2AF EB78 F886 40C9 B2A2 4AE2 C887 665E 0760
Re: [Axis2] Removing ContextListener
Posted by Afkham Azeez <af...@gmail.com>.
Hi Glen,
OK got it. I'll integrate this once I finish what I'm working on right now.
Thanks
Azeez
On 5/29/07, Glen Daniels <gl...@thoughtcraft.com> wrote:
>
> Hi Afkham!
>
> Afkham Azeez wrote:
> > Hi Glen,
> > When I checked the logs, I found that you have introduced this
> > interface. What is the usage of this interface?
>
> This was added because we refactored ContextFactory away - and the
> reason for ContextFactory was to have one place that we could be
> notified of all the *Context creations (even though it never actually
> did that!).
>
> See thread at http://marc.info/?l=axis-dev&m=117822877408932&w=2.
> Apparently no one integrated this into the actual clustering code.
>
> > In the clustering implementation, we need to track the add context &
> > remove context events for service group contexts & service contexts.
> > Currently we are directly calling cluster manager from the relevant
> > places. Can this interface be adopted by the clustering implementation?
>
> Well, that was the idea... :)
>
> Do whatever the right thing is. If you feel you're getting good mileage
> out of the current code and there isn't too much tight coupling, feel
> free to remove ContextListener and associated APIs. Otherwise feel free
> to utilize it.
>
> Thanks,
> --Glen
>
> > On 5/28/07, *Afkham Azeez* <afkham@gmail.com <ma...@gmail.com>>
> > wrote:
> >
> > The ContextListener interface is not used by the clustering
> > implementation. We directly call ContextManager.addContext() from
> > the relevant places.
> > Is this interface intended for any other purpose? Shall we remove
> it?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>
--
Thanks
Afkham Azeez
http://www.wso2.org
GPG Fingerprint: 643F C2AF EB78 F886 40C9 B2A2 4AE2 C887 665E 0760
Re: [Axis2] Removing ContextListener
Posted by Glen Daniels <gl...@thoughtcraft.com>.
Hi Afkham!
Afkham Azeez wrote:
> Hi Glen,
> When I checked the logs, I found that you have introduced this
> interface. What is the usage of this interface?
This was added because we refactored ContextFactory away - and the
reason for ContextFactory was to have one place that we could be
notified of all the *Context creations (even though it never actually
did that!).
See thread at http://marc.info/?l=axis-dev&m=117822877408932&w=2.
Apparently no one integrated this into the actual clustering code.
> In the clustering implementation, we need to track the add context &
> remove context events for service group contexts & service contexts.
> Currently we are directly calling cluster manager from the relevant
> places. Can this interface be adopted by the clustering implementation?
Well, that was the idea... :)
Do whatever the right thing is. If you feel you're getting good mileage
out of the current code and there isn't too much tight coupling, feel
free to remove ContextListener and associated APIs. Otherwise feel free
to utilize it.
Thanks,
--Glen
> On 5/28/07, *Afkham Azeez* <afkham@gmail.com <ma...@gmail.com>>
> wrote:
>
> The ContextListener interface is not used by the clustering
> implementation. We directly call ContextManager.addContext() from
> the relevant places.
> Is this interface intended for any other purpose? Shall we remove it?
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: [Axis2] Removing ContextListener
Posted by Afkham Azeez <af...@gmail.com>.
Hi Glen,
When I checked the logs, I found that you have introduced this interface.
What is the usage of this interface?
In the clustering implementation, we need to track the add context & remove
context events for service group contexts & service contexts. Currently we
are directly calling cluster manager from the relevant places. Can this
interface be adopted by the clustering implementation?
Thanks
Azeez
On 5/28/07, Afkham Azeez <af...@gmail.com> wrote:
>
> The ContextListener interface is not used by the clustering
> implementation. We directly call ContextManager.addContext() from the
> relevant places.
> Is this interface intended for any other purpose? Shall we remove it?
>
> --
> Thanks
> Afkham Azeez
>
> http://www.wso2.org
> GPG Fingerprint: 643F C2AF EB78 F886 40C9 B2A2 4AE2 C887 665E 0760
--
Thanks
Afkham Azeez
http://www.wso2.org
GPG Fingerprint: 643F C2AF EB78 F886 40C9 B2A2 4AE2 C887 665E 0760