You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Alexander Klimetschek (JIRA)" <ji...@apache.org> on 2008/11/03 21:58:44 UTC
[jira] Created: (SLING-717) I18n: messages with no sling:key
property stop enumeration of all keys
I18n: messages with no sling:key property stop enumeration of all keys
----------------------------------------------------------------------
Key: SLING-717
URL: https://issues.apache.org/jira/browse/SLING-717
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Alexander Klimetschek
If a sling:message node has no sling:key property, this will stop the ResourceBundleEnumeration, because the null key is added to the resources list in JcrResourceBundle.loadFully() and a null key is also interpreted as the "end marker" in ResourceBundleEnumeration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-717) I18n: messages with no sling:key
property stop enumeration of all keys
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-717:
---------------------------------------
Assignee: Felix Meschberger
> I18n: messages with no sling:key property stop enumeration of all keys
> ----------------------------------------------------------------------
>
> Key: SLING-717
> URL: https://issues.apache.org/jira/browse/SLING-717
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Reporter: Alexander Klimetschek
> Assignee: Felix Meschberger
> Attachments: SLING-717.fmeschbe.patch, SLING-717.patch
>
>
> If a sling:message node has no sling:key property, this will stop the ResourceBundleEnumeration, because the null key is added to the resources list in JcrResourceBundle.loadFully() and a null key is also interpreted as the "end marker" in ResourceBundleEnumeration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-717) I18n: messages with no sling:key
property stop enumeration of all keys
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-717:
------------------------------------
Attachment: SLING-717.fmeschbe.patch
The attached patch is propably not correct in that a message entry without a key should use the entry node's name as the key, such as in my attached patch.
> I18n: messages with no sling:key property stop enumeration of all keys
> ----------------------------------------------------------------------
>
> Key: SLING-717
> URL: https://issues.apache.org/jira/browse/SLING-717
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Reporter: Alexander Klimetschek
> Attachments: SLING-717.fmeschbe.patch, SLING-717.patch
>
>
> If a sling:message node has no sling:key property, this will stop the ResourceBundleEnumeration, because the null key is added to the resources list in JcrResourceBundle.loadFully() and a null key is also interpreted as the "end marker" in ResourceBundleEnumeration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-717) I18n: messages with no sling:key
property stop enumeration of all keys
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Klimetschek closed SLING-717.
---------------------------------------
Thanks for the quick action, changes work fine!
> I18n: messages with no sling:key property stop enumeration of all keys
> ----------------------------------------------------------------------
>
> Key: SLING-717
> URL: https://issues.apache.org/jira/browse/SLING-717
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Extensions i18n 2.0.2
> Reporter: Alexander Klimetschek
> Assignee: Felix Meschberger
> Fix For: Extensions i18n 2.0.2
>
> Attachments: SLING-717.fmeschbe.patch, SLING-717.patch
>
>
> If a sling:message node has no sling:key property, this will stop the ResourceBundleEnumeration, because the null key is added to the resources list in JcrResourceBundle.loadFully() and a null key is also interpreted as the "end marker" in ResourceBundleEnumeration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-717) I18n: messages with no sling:key
property stop enumeration of all keys
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Klimetschek updated SLING-717:
----------------------------------------
Attachment: SLING-717.patch
Patch that checks for null values of sling:key and skips them.
> I18n: messages with no sling:key property stop enumeration of all keys
> ----------------------------------------------------------------------
>
> Key: SLING-717
> URL: https://issues.apache.org/jira/browse/SLING-717
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Reporter: Alexander Klimetschek
> Attachments: SLING-717.patch
>
>
> If a sling:message node has no sling:key property, this will stop the ResourceBundleEnumeration, because the null key is added to the resources list in JcrResourceBundle.loadFully() and a null key is also interpreted as the "end marker" in ResourceBundleEnumeration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-717) I18n: messages with no sling:key
property stop enumeration of all keys
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-717:
------------------------------------
Fix Version/s: Extensions i18n 2.0.2
Affects Version/s: Extensions i18n 2.0.2
> I18n: messages with no sling:key property stop enumeration of all keys
> ----------------------------------------------------------------------
>
> Key: SLING-717
> URL: https://issues.apache.org/jira/browse/SLING-717
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Extensions i18n 2.0.2
> Reporter: Alexander Klimetschek
> Assignee: Felix Meschberger
> Fix For: Extensions i18n 2.0.2
>
> Attachments: SLING-717.fmeschbe.patch, SLING-717.patch
>
>
> If a sling:message node has no sling:key property, this will stop the ResourceBundleEnumeration, because the null key is added to the resources list in JcrResourceBundle.loadFully() and a null key is also interpreted as the "end marker" in ResourceBundleEnumeration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-717) I18n: messages with no sling:key
property stop enumeration of all keys
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644930#action_12644930 ]
Alexander Klimetschek commented on SLING-717:
---------------------------------------------
You are right, using the node name as fallback was actually a design goal in some earlier discussion. So I would prefer the second patch as well.
> I18n: messages with no sling:key property stop enumeration of all keys
> ----------------------------------------------------------------------
>
> Key: SLING-717
> URL: https://issues.apache.org/jira/browse/SLING-717
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Reporter: Alexander Klimetschek
> Attachments: SLING-717.fmeschbe.patch, SLING-717.patch
>
>
> If a sling:message node has no sling:key property, this will stop the ResourceBundleEnumeration, because the null key is added to the resources list in JcrResourceBundle.loadFully() and a null key is also interpreted as the "end marker" in ResourceBundleEnumeration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-717) I18n: messages with no sling:key
property stop enumeration of all keys
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-717.
-------------------------------------
Resolution: Fixed
Implemented the change in Rev. 711247.
Please close this issue, if this fixes your problem. Thanks.
> I18n: messages with no sling:key property stop enumeration of all keys
> ----------------------------------------------------------------------
>
> Key: SLING-717
> URL: https://issues.apache.org/jira/browse/SLING-717
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Extensions i18n 2.0.2
> Reporter: Alexander Klimetschek
> Assignee: Felix Meschberger
> Attachments: SLING-717.fmeschbe.patch, SLING-717.patch
>
>
> If a sling:message node has no sling:key property, this will stop the ResourceBundleEnumeration, because the null key is added to the resources list in JcrResourceBundle.loadFully() and a null key is also interpreted as the "end marker" in ResourceBundleEnumeration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.