You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by Janne Jalkanen <ja...@ecyrd.com> on 2009/02/10 21:37:51 UTC
Re: svn commit: r742661 - in /incubator/jspwiki/trunk: ./ .settings/ src/java/org/apache/wiki/plugin/ tests/java/org/apache/wiki/plugin/
Yeah, the idea of having WebContent is that we can put all the
resources in the right places from the get-go...
/Janne
On 10 Feb 2009, at 22:31, Harry Metske wrote:
> you mean moving it to WEB-INF/classes ?
>
> that's also a possibility, needs some tweaks to build.xml
>
> Harry
>
> 2009/2/9 Janne Jalkanen <ja...@ecyrd.com>
>
>> * added etc/i18n to the classpath and changed project setting
>> "Allow
>>> output folders
>>> as source folders", this makes it possible to run individual
>>> JUnit
>>> tests again.
>>>
>>
>> Shouldn't etc/i18n -files be rather under WEB-INF? Or should they
>> go under
>> src/resources?
>>
>> /Janne
>>
Re: svn commit: r742661 - in /incubator/jspwiki/trunk: ./ .settings/ src/java/org/apache/wiki/plugin/ tests/java/org/apache/wiki/plugin/
Posted by Andrew Jaquith <an...@gmail.com>.
Yes, the rename is also a very good idea...
On Feb 14, 2009, at 4:52, Janne Jalkanen <ja...@ecyrd.com>
wrote:
>
> Yup, +1 from me too.
>
> We might also want to rename them to DenouncePlugin.properties and
> ProfanityFilter.properties to make sure they are aligned with the
> plugin names. ATM they're not that descriptive.
>
> /Janne
>
> On 14 Feb 2009, at 01:31, Andrew Jaquith wrote:
>
>> +1
>>
>> On Feb 13, 2009, at 14:44, Harry Metske <ha...@gmail.com>
>> wrote:
>>
>>> then I'd also like to move
>>>
>>> src/java/org/apache/wiki/plugin/denounce.properties
>>> src/java/org/apache/wiki/filters/profanity.properties
>>>
>>> to
>>>
>>> src/WebContent/WEB-INF/classes/denounce.properties
>>> src/WebContent/WEB-INF/classes/profanity.properties
>>>
>>> we then have most property files together.
>>>
>>> /Harry
>>>
>>> 2009/2/10 Janne Jalkanen <ja...@ecyrd.com>
>>>
>>>>
>>>> Yeah, the idea of having WebContent is that we can put all the
>>>> resources in
>>>> the right places from the get-go...
>>>>
>>>> /Janne
>>>>
>>>>
>>>> On 10 Feb 2009, at 22:31, Harry Metske wrote:
>>>>
>>>> you mean moving it to WEB-INF/classes ?
>>>>>
>>>>> that's also a possibility, needs some tweaks to build.xml
>>>>>
>>>>> Harry
>>>>>
>>>>> 2009/2/9 Janne Jalkanen <ja...@ecyrd.com>
>>>>>
>>>>> * added etc/i18n to the classpath and changed project setting
>>>>> "Allow
>>>>>>
>>>>>>> output folders
>>>>>>> as source folders", this makes it possible to run individual
>>>>>>> JUnit
>>>>>>> tests again.
>>>>>>>
>>>>>>>
>>>>>> Shouldn't etc/i18n -files be rather under WEB-INF? Or should
>>>>>> they go
>>>>>> under
>>>>>> src/resources?
>>>>>>
>>>>>> /Janne
>>>>>>
>>>>>>
>>>>
>
Re: svn commit: r742661 - in /incubator/jspwiki/trunk: ./ .settings/ src/java/org/apache/wiki/plugin/ tests/java/org/apache/wiki/plugin/
Posted by Janne Jalkanen <ja...@ecyrd.com>.
Yup, +1 from me too.
We might also want to rename them to DenouncePlugin.properties and
ProfanityFilter.properties to make sure they are aligned with the
plugin names. ATM they're not that descriptive.
/Janne
On 14 Feb 2009, at 01:31, Andrew Jaquith wrote:
> +1
>
> On Feb 13, 2009, at 14:44, Harry Metske <ha...@gmail.com>
> wrote:
>
>> then I'd also like to move
>>
>> src/java/org/apache/wiki/plugin/denounce.properties
>> src/java/org/apache/wiki/filters/profanity.properties
>>
>> to
>>
>> src/WebContent/WEB-INF/classes/denounce.properties
>> src/WebContent/WEB-INF/classes/profanity.properties
>>
>> we then have most property files together.
>>
>> /Harry
>>
>> 2009/2/10 Janne Jalkanen <ja...@ecyrd.com>
>>
>>>
>>> Yeah, the idea of having WebContent is that we can put all the
>>> resources in
>>> the right places from the get-go...
>>>
>>> /Janne
>>>
>>>
>>> On 10 Feb 2009, at 22:31, Harry Metske wrote:
>>>
>>> you mean moving it to WEB-INF/classes ?
>>>>
>>>> that's also a possibility, needs some tweaks to build.xml
>>>>
>>>> Harry
>>>>
>>>> 2009/2/9 Janne Jalkanen <ja...@ecyrd.com>
>>>>
>>>> * added etc/i18n to the classpath and changed project setting
>>>> "Allow
>>>>>
>>>>>> output folders
>>>>>> as source folders", this makes it possible to run individual
>>>>>> JUnit
>>>>>> tests again.
>>>>>>
>>>>>>
>>>>> Shouldn't etc/i18n -files be rather under WEB-INF? Or should
>>>>> they go
>>>>> under
>>>>> src/resources?
>>>>>
>>>>> /Janne
>>>>>
>>>>>
>>>
Re: svn commit: r742661 - in /incubator/jspwiki/trunk: ./ .settings/ src/java/org/apache/wiki/plugin/ tests/java/org/apache/wiki/plugin/
Posted by Andrew Jaquith <an...@gmail.com>.
+1
On Feb 13, 2009, at 14:44, Harry Metske <ha...@gmail.com> wrote:
> then I'd also like to move
>
> src/java/org/apache/wiki/plugin/denounce.properties
> src/java/org/apache/wiki/filters/profanity.properties
>
> to
>
> src/WebContent/WEB-INF/classes/denounce.properties
> src/WebContent/WEB-INF/classes/profanity.properties
>
> we then have most property files together.
>
> /Harry
>
> 2009/2/10 Janne Jalkanen <ja...@ecyrd.com>
>
>>
>> Yeah, the idea of having WebContent is that we can put all the
>> resources in
>> the right places from the get-go...
>>
>> /Janne
>>
>>
>> On 10 Feb 2009, at 22:31, Harry Metske wrote:
>>
>> you mean moving it to WEB-INF/classes ?
>>>
>>> that's also a possibility, needs some tweaks to build.xml
>>>
>>> Harry
>>>
>>> 2009/2/9 Janne Jalkanen <ja...@ecyrd.com>
>>>
>>> * added etc/i18n to the classpath and changed project setting
>>> "Allow
>>>>
>>>>> output folders
>>>>> as source folders", this makes it possible to run individual
>>>>> JUnit
>>>>> tests again.
>>>>>
>>>>>
>>>> Shouldn't etc/i18n -files be rather under WEB-INF? Or should
>>>> they go
>>>> under
>>>> src/resources?
>>>>
>>>> /Janne
>>>>
>>>>
>>
Re: svn commit: r742661 - in /incubator/jspwiki/trunk: ./ .settings/
src/java/org/apache/wiki/plugin/ tests/java/org/apache/wiki/plugin/
Posted by Harry Metske <ha...@gmail.com>.
then I'd also like to move
src/java/org/apache/wiki/plugin/denounce.properties
src/java/org/apache/wiki/filters/profanity.properties
to
src/WebContent/WEB-INF/classes/denounce.properties
src/WebContent/WEB-INF/classes/profanity.properties
we then have most property files together.
/Harry
2009/2/10 Janne Jalkanen <ja...@ecyrd.com>
>
> Yeah, the idea of having WebContent is that we can put all the resources in
> the right places from the get-go...
>
> /Janne
>
>
> On 10 Feb 2009, at 22:31, Harry Metske wrote:
>
> you mean moving it to WEB-INF/classes ?
>>
>> that's also a possibility, needs some tweaks to build.xml
>>
>> Harry
>>
>> 2009/2/9 Janne Jalkanen <ja...@ecyrd.com>
>>
>> * added etc/i18n to the classpath and changed project setting "Allow
>>>
>>>> output folders
>>>> as source folders", this makes it possible to run individual JUnit
>>>> tests again.
>>>>
>>>>
>>> Shouldn't etc/i18n -files be rather under WEB-INF? Or should they go
>>> under
>>> src/resources?
>>>
>>> /Janne
>>>
>>>
>