You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@spamassassin.apache.org by Cecil Westerhof <Ce...@decebal.nl> on 2012/12/26 16:55:37 UTC

Scoring of old rules is still done

In the past I asked this question, but I was told that it was because
of my own rules. I never defined my own rules, So I try the question
again.

I have the following script to update SpamAssassin:
    #!/usr/bin/env bash

    declare -r GREP_REGEX='not installed\|warning'
    declare -r LOG_FILE='sa-update.log'

    declare PID
    declare retVal

    cd
    sa-update -D 2>${LOG_FILE}
    retVal=${?}
    case ${retVal} in
      0)
        echo "Updated SpamAssassin rules"
        /etc/init.d/spamd reload
        ;;
      1)
        echo "There where no updates for SpamAssassin rules"
        ;;
      2)
        echo "There are updates, but lint check failed"
        ;;
      3)
        echo "Unknown error"
        ;;
      *)
        echo "Error while trying to download SpamAssasin rules"
        ;;
    esac
    echo
    grep "${GREP_REGEX}" ${LOG_FILE}

When the rules are updated, I get something like:
    Updated SpamAssassin rules
    Reload service spamd ..done

    Dec 26 03:04:13.110 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H4
    Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_WL
    Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule HK_NAME_FM_MR_MRS
    Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L5
    Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H3
    Dec 26 03:04:13.118 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H2
    Dec 26 03:04:13.118 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_ZBI
    Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L2
    Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule HK_NAME_MR_MRS
    Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_BL
    Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L4
    Dec 26 03:04:13.120 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H5
    Dec 26 03:04:13.120 [17074] dbg: config: warning: score set for non-existent rule URIBL_SBL_A
    Dec 26 03:04:13.120 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L3

So it looks to me that rules that are not used anymore are deleted,
but there scoring not.

Should the scorings not be deleted also?

--
Cecil Westerhof
Senior Software Engineer
LinkedIn: http://www.linkedin.com/in/cecilwesterhof

Re: Scoring of old rules is still done

Posted by Cecil Westerhof <Ce...@decebal.nl>.
Op woensdag 26 dec 2012 23:12 CET schreef Kevin A. McGrail:

> On 12/26/2012 3:54 PM, Cecil Westerhof wrote:
>> Op woensdag 26 dec 2012 21:22 CET schreef Kevin A. McGrail:
>>
>>> These errors relate to the fact that those rules are encapsulated
>>> with a version check that is likely above your version.
>>>
>>> They can be safely ignored.
>> In my mailspike I see:
>> # MailSpike is included in SpamAssassin 3.4+
>> if (version >= 3.004000)
>>
>> While the latest version (which I am running) is:
>> 3.3.2
>>
>> So why wants mailspike 3.4+?
> 3.4 is the version of the current development trunk.
>
> Mailspike was targetted for 3.4
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6400#c5
>
> You can either: ignore the error with 3.3.2, use the trunk version
> or wait for 3.4. I'm going to push an RC of 3.4 before year end if I
> can help it!

OK, I understand it now. I'll just ignore it then.

-- 
Cecil Westerhof
Senior Software Engineer
LinkedIn: http://www.linkedin.com/in/cecilwesterhof

Re: Scoring of old rules is still done

Posted by "Kevin A. McGrail" <KM...@PCCC.com>.
On 12/26/2012 3:54 PM, Cecil Westerhof wrote:
> Op woensdag 26 dec 2012 21:22 CET schreef Kevin A. McGrail:
>
>> These errors relate to the fact that those rules are encapsulated
>> with a version check that is likely above your version.
>>
>> They can be safely ignored.
> In my mailspike I see:
>      # MailSpike is included in SpamAssassin 3.4+
>      if (version >= 3.004000)
>
> While the latest version (which I am running) is:
>      3.3.2
>
> So why wants mailspike 3.4+?
3.4 is the version of the current development trunk.

Mailspike was targetted for 3.4 
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6400#c5

You can either: ignore the error with 3.3.2, use the trunk version or 
wait for 3.4.  I'm going to push an RC of 3.4 before year end if I can 
help it!

Regards,
KAM

Re: Scoring of old rules is still done

Posted by Cecil Westerhof <Ce...@decebal.nl>.
Op woensdag 26 dec 2012 21:22 CET schreef Kevin A. McGrail:

> These errors relate to the fact that those rules are encapsulated
> with a version check that is likely above your version.
>
> They can be safely ignored.

In my mailspike I see:
    # MailSpike is included in SpamAssassin 3.4+
    if (version >= 3.004000)

While the latest version (which I am running) is:
    3.3.2

So why wants mailspike 3.4+?

-- 
Cecil Westerhof
Senior Software Engineer
LinkedIn: http://www.linkedin.com/in/cecilwesterhof

Re: Scoring of old rules is still done

Posted by "Kevin A. McGrail" <KM...@PCCC.com>.
On 12/26/2012 10:55 AM, Cecil Westerhof wrote:
>      Dec 26 03:04:13.110 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H4
>      Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_WL
>      Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule HK_NAME_FM_MR_MRS
>      Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L5
>      Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H3
>      Dec 26 03:04:13.118 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H2
>      Dec 26 03:04:13.118 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_ZBI
>      Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L2
>      Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule HK_NAME_MR_MRS
>      Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_BL
>      Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L4
>      Dec 26 03:04:13.120 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H5
>      Dec 26 03:04:13.120 [17074] dbg: config: warning: score set for non-existent rule URIBL_SBL_A
>      Dec 26 03:04:13.120 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L3
>
> So it looks to me that rules that are not used anymore are deleted,
> but there scoring not.
>
> Should the scorings not be deleted also?

These errors relate to the fact that those rules are encapsulated with a 
version check that is likely above your version.

They can be safely ignored.

regards,
KAm

Re: Scoring of old rules is still done

Posted by Cecil Westerhof <Ce...@decebal.nl>.
Op woensdag 26 dec 2012 17:17 CET schreef John ffitch:

> A looked at my rules for one of those
>
> snout:/var/lib/spamassassin/3.003002# grep RCVD_IN_MSPIKE_BL */*
> updates_spamassassin_org/20_mailspike.cf:meta RCVD_IN_MSPIKE_BL
> RCVD_IN_MSPIKE_L5 || RCVD_IN_MSPIKE_L4 || RCVD_IN_MSPIKE_L3 ||
> __RCVD_IN_MSPIKE_Z updates_spamassassin_org/20_mailspike.cf:describe
> RCVD_IN_MSPIKE_BL Mailspike blacklisted
> updates_spamassassin_org/20_mailspike.cf:tflags RCVD_IN_MSPIKE_BL
> net updates_spamassassin_org/50_scores.cf: score RCVD_IN_MSPIKE_BL
> 0.01 updates_spamassassin_org/72_scores.cf:score RCVD_IN_MSPIKE_BL
> 0.001 0.010 0.001 0.010
>
> So this is defined in updates_spamassassin_org/20_mailspike.cf
> which suggests that one of us is out of step......
> ==John ff

In my mailspike I see:
    # MailSpike is included in SpamAssassin 3.4+
    if (version >= 3.004000)

While the latest version (which I am running) is:
    3.3.2

-- 
Cecil Westerhof
Senior Software Engineer
LinkedIn: http://www.linkedin.com/in/cecilwesterhof

Re: Scoring of old rules is still done

Posted by John ffitch <jp...@codemist.co.uk>.
A looked at my rules for one of those

snout:/var/lib/spamassassin/3.003002# grep RCVD_IN_MSPIKE_BL */*
updates_spamassassin_org/20_mailspike.cf:meta RCVD_IN_MSPIKE_BL 
RCVD_IN_MSPIKE_L5 || RCVD_IN_MSPIKE_L4 || RCVD_IN_MSPIKE_L3 || 
__RCVD_IN_MSPIKE_Z
updates_spamassassin_org/20_mailspike.cf:describe RCVD_IN_MSPIKE_BL 
Mailspike blacklisted
updates_spamassassin_org/20_mailspike.cf:tflags RCVD_IN_MSPIKE_BL 
net
updates_spamassassin_org/50_scores.cf:  score RCVD_IN_MSPIKE_BL      0.01
updates_spamassassin_org/72_scores.cf:score RCVD_IN_MSPIKE_BL 
0.001 0.010 0.001 0.010

So this is defined in updates_spamassassin_org/20_mailspike.cf
which suggests that one of us is out of step......
==John ff



Re: Scoring of old rules is still done

Posted by Cecil Westerhof <Ce...@decebal.nl>.
Op woensdag 26 dec 2012 17:17 CET schreef jdow@earthlink.net:

> sa-update should have picked up the mailspike rules. I suppose you
> did something to remove updates_spamassassin_org/20_mailspike.cf.
> And then you did nothing to the
> updates_spamassassin_org/72_scores.cf scores file to remove scores
> for mailspike.
>
> If you wanted mailspike out of there the better approach is to build
> a 99_myoverrides.cf file that includes "score XXXX 0" scores. That
> survives updates and is processed last so it overrides earlier
> settings that might override.

As far as I know I did nothing, but maybe I am wrong.

But mailspike is still there:
    -rw-r--r-- 1 root root 8.5K Dec 26 03:04 10_default_prefs.cf
    -rw-r--r-- 1 root root 2.4K Dec 26 03:04 10_hasbase.cf
    -rw-r--r-- 1 root root 7.5K Dec 26 03:04 20_advance_fee.cf
    -rw-r--r-- 1 root root 8.5K Dec 26 03:04 20_aux_tlds.cf
    -rw-r--r-- 1 root root 6.9K Dec 26 03:04 20_body_tests.cf
    -rw-r--r-- 1 root root 1.9K Dec 26 03:04 20_compensate.cf
    -rw-r--r-- 1 root root  11K Dec 26 03:04 20_dnsbl_tests.cf
    -rw-r--r-- 1 root root  15K Dec 26 03:04 20_drugs.cf
    -rw-r--r-- 1 root root  12K Dec 26 03:04 20_dynrdns.cf
    -rw-r--r-- 1 root root 8.4K Dec 26 03:04 20_fake_helo_tests.cf
    -rw-r--r-- 1 root root 3.0K Dec 26 03:04 20_freemail.cf
    -rw-r--r-- 1 root root  36K Dec 26 03:04 20_freemail_domains.cf
    -rw-r--r-- 1 root root  26K Dec 26 03:04 20_head_tests.cf
    -rw-r--r-- 1 root root  11K Dec 26 03:04 20_html_tests.cf
    -rw-r--r-- 1 root root 5.2K Dec 26 03:04 20_imageinfo.cf
    -rw-r--r-- 1 root root 2.6K Dec 26 03:04 20_mailspike.cf
    -rw-r--r-- 1 root root 3.3K Dec 26 03:04 20_meta_tests.cf
    -rw-r--r-- 1 root root 1.9K Dec 26 03:04 20_net_tests.cf
    -rw-r--r-- 1 root root 8.0K Dec 26 03:04 20_phrases.cf
    -rw-r--r-- 1 root root 2.1K Dec 26 03:04 20_porn.cf
    -rw-r--r-- 1 root root  16K Dec 26 03:04 20_ratware.cf
    -rw-r--r-- 1 root root 5.6K Dec 26 03:04 20_uri_tests.cf
    -rw-r--r-- 1 root root  19K Dec 26 03:04 20_vbounce.cf
    -rw-r--r-- 1 root root 2.5K Dec 26 03:04 23_bayes.cf
    -rw-r--r-- 1 root root 1.6K Dec 26 03:04 25_accessdb.cf
    -rw-r--r-- 1 root root 1.6K Dec 26 03:04 25_antivirus.cf
    -rw-r--r-- 1 root root 1.6K Dec 26 03:04 25_asn.cf
    -rw-r--r-- 1 root root 2.3K Dec 26 03:04 25_dcc.cf
    -rw-r--r-- 1 root root 4.4K Dec 26 03:04 25_dkim.cf
    -rw-r--r-- 1 root root 2.9K Dec 26 03:04 25_hashcash.cf
    -rw-r--r-- 1 root root 1.3K Dec 26 03:04 25_pyzor.cf
    -rw-r--r-- 1 root root 3.4K Dec 26 03:04 25_razor2.cf
    -rw-r--r-- 1 root root 7.6K Dec 26 03:04 25_replace.cf
    -rw-r--r-- 1 root root 3.4K Dec 26 03:04 25_spf.cf
    -rw-r--r-- 1 root root 1.8K Dec 26 03:04 25_textcat.cf
    -rw-r--r-- 1 root root  11K Dec 26 03:04 25_uribl.cf
    -rw-r--r-- 1 root root  28K Dec 26 03:04 30_text_de.cf
    -rw-r--r-- 1 root root  21K Dec 26 03:04 30_text_fr.cf
    -rw-r--r-- 1 root root 1.9K Dec 26 03:04 30_text_it.cf
    -rw-r--r-- 1 root root  22K Dec 26 03:04 30_text_nl.cf
    -rw-r--r-- 1 root root  18K Dec 26 03:04 30_text_pl.cf
    -rw-r--r-- 1 root root  45K Dec 26 03:04 30_text_pt_br.cf
    -rw-r--r-- 1 root root  44K Dec 26 03:04 50_scores.cf
    -rw-r--r-- 1 root root 9.1K Dec 26 03:04 60_adsp_override_dkim.cf
    -rw-r--r-- 1 root root 1.3K Dec 26 03:04 60_awl.cf
    -rw-r--r-- 1 root root 2.2K Dec 26 03:04 60_shortcircuit.cf
    -rw-r--r-- 1 root root 4.9K Dec 26 03:04 60_whitelist.cf
    -rw-r--r-- 1 root root 6.1K Dec 26 03:04 60_whitelist_dkim.cf
    -rw-r--r-- 1 root root 3.6K Dec 26 03:04 60_whitelist_spf.cf
    -rw-r--r-- 1 root root 1.9K Dec 26 03:04 60_whitelist_subject.cf
    -rw-r--r-- 1 root root 226K Dec 26 03:04 72_active.cf
    -rw-r--r-- 1 root root  11K Dec 26 03:04 72_scores.cf
    -rw-r--r-- 1 root root 2.3K Dec 26 03:04 73_sandbox_manual_scores.cf
    -rw-r--r-- 1 root root  299 Dec 26 03:04 MIRRORED.BY
    -rw-r--r-- 1 root root 1.5K Dec 26 03:04 STATISTICS-set0-72_scores.cf.txt
    -rw-r--r-- 1 root root 1.5K Dec 26 03:04 STATISTICS-set1-72_scores.cf.txt
    -rw-r--r-- 1 root root    0 Dec 26 03:04 STATISTICS-set2-72_scores.cf.txt
    -rw-r--r-- 1 root root    0 Dec 26 03:04 STATISTICS-set3-72_scores.cf.txt
    -rw-r--r-- 1 root root 100K Dec 26 03:04 languages
    -rw-r--r-- 1 root root 2.2K Dec 26 03:04 local.cf
    -rw-r--r-- 1 root root 2.7K Dec 26 03:04 regression_tests.cf
    -rw-r--r-- 1 root root 4.7K Dec 26 03:04 sa-update-pubkey.txt
    -rw-r--r-- 1 root root 1.9K Dec 26 03:04 user_prefs.template

When I look into mailspike I see:
    # MailSpike is included in SpamAssassin 3.4+
    if (version >= 3.004000)

But when I look at http://spamassassin.apache.org/ the the latest
version is:
     3.3.2

That is also the version I am running.

Is something else missing?

-- 
Cecil Westerhof
Senior Software Engineer
LinkedIn: http://www.linkedin.com/in/cecilwesterhof

Re: Scoring of old rules is still done

Posted by jdow <jd...@earthlink.net>.
sa-update should have picked up the mailspike rules. I suppose
you did something to remove updates_spamassassin_org/20_mailspike.cf.
And then you did nothing to the updates_spamassassin_org/72_scores.cf
scores file to remove scores for mailspike.

If you wanted mailspike out of there the better approach is to build
a 99_myoverrides.cf file that includes "score XXXX 0" scores. That
survives updates and is processed last so it overrides earlier
settings that might override.

{o.o}

On 2012/12/26 07:55, Cecil Westerhof wrote:
> In the past I asked this question, but I was told that it was because
> of my own rules. I never defined my own rules, So I try the question
> again.
>
> I have the following script to update SpamAssassin:
>      #!/usr/bin/env bash
>
>      declare -r GREP_REGEX='not installed\|warning'
>      declare -r LOG_FILE='sa-update.log'
>
>      declare PID
>      declare retVal
>
>      cd
>      sa-update -D 2>${LOG_FILE}
>      retVal=${?}
>      case ${retVal} in
>        0)
>          echo "Updated SpamAssassin rules"
>          /etc/init.d/spamd reload
>          ;;
>        1)
>          echo "There where no updates for SpamAssassin rules"
>          ;;
>        2)
>          echo "There are updates, but lint check failed"
>          ;;
>        3)
>          echo "Unknown error"
>          ;;
>        *)
>          echo "Error while trying to download SpamAssasin rules"
>          ;;
>      esac
>      echo
>      grep "${GREP_REGEX}" ${LOG_FILE}
>
> When the rules are updated, I get something like:
>      Updated SpamAssassin rules
>      Reload service spamd ..done
>
>      Dec 26 03:04:13.110 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H4
>      Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_WL
>      Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule HK_NAME_FM_MR_MRS
>      Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L5
>      Dec 26 03:04:13.111 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H3
>      Dec 26 03:04:13.118 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H2
>      Dec 26 03:04:13.118 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_ZBI
>      Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L2
>      Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule HK_NAME_MR_MRS
>      Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_BL
>      Dec 26 03:04:13.119 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L4
>      Dec 26 03:04:13.120 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_H5
>      Dec 26 03:04:13.120 [17074] dbg: config: warning: score set for non-existent rule URIBL_SBL_A
>      Dec 26 03:04:13.120 [17074] dbg: config: warning: score set for non-existent rule RCVD_IN_MSPIKE_L3
>
> So it looks to me that rules that are not used anymore are deleted,
> but there scoring not.
>
> Should the scorings not be deleted also?
>
> --
> Cecil Westerhof
> Senior Software Engineer
> LinkedIn: http://www.linkedin.com/in/cecilwesterhof
>