You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2022/08/11 18:27:43 UTC

[superset] branch hugh-2 created (now a24de5d397)

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a change to branch hugh-2
in repository https://gitbox.apache.org/repos/asf/superset.git


      at a24de5d397 fix

This branch includes the following new commits:

     new 3fd88b85bb take form_data reference for form_data
     new a24de5d397 fix

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[superset] 02/02: fix

Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh-2
in repository https://gitbox.apache.org/repos/asf/superset.git

commit a24de5d3972e15836d8a1275e4afdac31bd1fc77
Author: hughhhh <hu...@gmail.com>
AuthorDate: Thu Aug 11 14:26:51 2022 -0400

    fix
---
 superset/charts/data/api.py          | 6 ++++++
 superset/reports/commands/execute.py | 5 +++++
 2 files changed, 11 insertions(+)

diff --git a/superset/charts/data/api.py b/superset/charts/data/api.py
index c20fdde6fd..6a350d704e 100644
--- a/superset/charts/data/api.py
+++ b/superset/charts/data/api.py
@@ -339,6 +339,12 @@ class ChartDataRestApi(ChartRestApi):
         # Post-process the data so it matches the data presented in the chart.
         # This is needed for sending reports based on text charts that do the
         # post-processing of data, eg, the pivot table.
+        logger.info(
+            "report_type: %s report_format: %s result: %s",
+            result_type,
+            result_format,
+            result,
+        )
         if result_type == ChartDataResultType.POST_PROCESSED:
             result = apply_post_process(result, form_data, datasource)
 
diff --git a/superset/reports/commands/execute.py b/superset/reports/commands/execute.py
index ad1b1edcd2..9c93b353a1 100644
--- a/superset/reports/commands/execute.py
+++ b/superset/reports/commands/execute.py
@@ -154,6 +154,11 @@ class BaseReportState:
         Get the url for this report schedule: chart or dashboard
         """
         force = "true" if self._report_schedule.force_screenshot else "false"
+        logger.info(
+            "chart_id: %d report_format: %s",
+            self._report_schedule.chart_id,
+            result_format,
+        )
         if self._report_schedule.chart:
             if result_format in {
                 ChartDataResultFormat.CSV,


[superset] 01/02: take form_data reference for form_data

Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh-2
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 3fd88b85bbd1e128a6f811c9d86d3b5da0378cba
Author: hughhhh <hu...@gmail.com>
AuthorDate: Tue Aug 9 12:20:32 2022 -0400

    take form_data reference for form_data
---
 superset/charts/post_processing.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/charts/post_processing.py b/superset/charts/post_processing.py
index 81d2a09b04..0efdc509bc 100644
--- a/superset/charts/post_processing.py
+++ b/superset/charts/post_processing.py
@@ -235,7 +235,7 @@ def pivot_table_v2(
         df,
         rows=get_column_names(form_data.get("groupbyRows"), verbose_map),
         columns=get_column_names(form_data.get("groupbyColumns"), verbose_map),
-        metrics=get_metric_names(form_data["metrics"], verbose_map),
+        metrics=get_metric_names(form_data["metrics"]),
         aggfunc=form_data.get("aggregateFunction", "Sum"),
         transpose_pivot=bool(form_data.get("transposePivot")),
         combine_metrics=bool(form_data.get("combineMetric")),