You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by venkata madugundu <ve...@in.ibm.com> on 2016/05/03 10:52:10 UTC
Review Request 46930: The Dashboard V2 project fails to build on
Windows
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46930/
-----------------------------------------------------------
Review request for atlas and David Kantor.
Bugs: ATLAS-732
https://issues.apache.org/jira/browse/ATLAS-732
Repository: atlas
Description
-------
The Dashboard V2 project fails to build on Windows...
---------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.23:install-node-and-npm (install node and npm) on project atlas-dashboardv2: Could not download Node.js from: http://nodejs.org/dist/v4.4.2/x64/node.exe: Got error code 404 from the server. -> [Help 1]
---------------------------------------------------------------
After bumping the version of frontend-maven-plugin from 0.0.23 to latest release 0.0.29 in the root pom.xml, the build was successful.
Cause - The node.exe is now made available at http://nodejs.org/dist/v4.4.2/win-x64/node.exe instead of http://nodejs.org/dist/v4.4.2/x64/node.exe. And the change in location seems to be working fine with latest frontend-maven-plugin.
This has been fixed by later version of frontend-maven-plugin plugin (please see - https://github.com/eirslett/frontend-maven-plugin/pull/284)
Diffs
-----
pom.xml c14e0b3a056cc588e281f3f38ddfdfd803ba458b
Diff: https://reviews.apache.org/r/46930/diff/
Testing
-------
Built the complete Atlas and ran the UI for sanity.
Thanks,
venkata madugundu
Re: Review Request 46930: The Dashboard V2 project fails to build on
Windows
Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46930/#review131620
-----------------------------------------------------------
Ship it!
This looks fine to me. Built on my MAC and things are fine. I use mvn 3.3.3. With older maven versions, there have been issues with the node plugins. So, will request Shwetha to check once and if OK, I can commit.
- Hemanth Yamijala
On May 3, 2016, 8:52 a.m., venkata madugundu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46930/
> -----------------------------------------------------------
>
> (Updated May 3, 2016, 8:52 a.m.)
>
>
> Review request for atlas and David Kantor.
>
>
> Bugs: ATLAS-732
> https://issues.apache.org/jira/browse/ATLAS-732
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The Dashboard V2 project fails to build on Windows...
> ---------------------------------------------------------------
> [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.23:install-node-and-npm (install node and npm) on project atlas-dashboardv2: Could not download Node.js from: http://nodejs.org/dist/v4.4.2/x64/node.exe: Got error code 404 from the server. -> [Help 1]
> ---------------------------------------------------------------
> After bumping the version of frontend-maven-plugin from 0.0.23 to latest release 0.0.29 in the root pom.xml, the build was successful.
> Cause - The node.exe is now made available at http://nodejs.org/dist/v4.4.2/win-x64/node.exe instead of http://nodejs.org/dist/v4.4.2/x64/node.exe. And the change in location seems to be working fine with latest frontend-maven-plugin.
>
> This has been fixed by later version of frontend-maven-plugin plugin (please see - https://github.com/eirslett/frontend-maven-plugin/pull/284)
>
>
> Diffs
> -----
>
> pom.xml c14e0b3a056cc588e281f3f38ddfdfd803ba458b
>
> Diff: https://reviews.apache.org/r/46930/diff/
>
>
> Testing
> -------
>
> Built the complete Atlas and ran the UI for sanity.
>
>
> Thanks,
>
> venkata madugundu
>
>