You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Baptiste MATHUS (JIRA)" <ji...@codehaus.org> on 2010/05/25 17:47:12 UTC

[jira] Created: (MRELEASE-564) Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration

Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration
--------------------------------------------------------------------------------------------------------

                 Key: MRELEASE-564
                 URL: http://jira.codehaus.org/browse/MRELEASE-564
             Project: Maven 2.x Release Plugin
          Issue Type: Improvement
          Components: prepare
    Affects Versions: 2.0-beta-9
            Reporter: Baptiste MATHUS
            Priority: Critical


Recently, I realized we rolled a released containing a reference onto a -SNAPSHOT version of our quality rules :/.

This was because of the following remote-resources plugin configuration:
{code:xml}
<plugin>
  <artifactId>maven-remote-resources-plugin</artifactId>
  <version>1.1</version>
  <executions>
    <execution>
      <goals>
        <goal>process</goal>
      </goals>
      <configuration>
        <resourceBundles>
          <resourceBundle>fr.comp-shared-resources:1.0-SNAPSHOT</resourceBundle>
        </resourceBundles>
      </configuration>
    </execution>
  </executions>
</plugin>
{code}

I think release:prepare should fail when it detects this.
I seem to remember it's a bad practice to read other plugin's config, but I file this issue because:
* remote-resources-plugin is a standard maven plugin, so I guess this use is to be often encountered
* this is a very important issue and I'd like to file it somewhere. Please let me know if I should file or discuss it somewhere else.

Cheers

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MRELEASE-564) Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MRELEASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=271348#comment-271348 ] 

Brett Porter commented on MRELEASE-564:
---------------------------------------

I'm not sure what the best general policy is either - we don't just want to deal with the remote resources plugin. Maybe check for pattern and allow excluded configuration?

> Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-564
>                 URL: https://jira.codehaus.org/browse/MRELEASE-564
>             Project: Maven 2.x Release Plugin
>          Issue Type: Improvement
>          Components: prepare
>    Affects Versions: 2.0-beta-9
>            Reporter: Baptiste MATHUS
>            Priority: Critical
>
> Recently, I realized we rolled a released containing a reference onto a -SNAPSHOT version of our quality rules :/.
> This was because of the following remote-resources plugin configuration:
> {code:xml}
> <plugin>
>   <artifactId>maven-remote-resources-plugin</artifactId>
>   <version>1.1</version>
>   <executions>
>     <execution>
>       <goals>
>         <goal>process</goal>
>       </goals>
>       <configuration>
>         <resourceBundles>
>           <resourceBundle>fr.comp-shared-resources:1.0-SNAPSHOT</resourceBundle>
>         </resourceBundles>
>       </configuration>
>     </execution>
>   </executions>
> </plugin>
> {code}
> I think release:prepare should fail when it detects this.
> I seem to remember it's a bad practice to read other plugin's config, but I file this issue because:
> * remote-resources-plugin is a standard maven plugin, so I guess this use is to be often encountered
> * this is a very important issue and I'd like to file it somewhere. Please let me know if I should file or discuss it somewhere else.
> Cheers

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MRELEASE-564) Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRELEASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236728#action_236728 ] 

Brett Porter commented on MRELEASE-564:
---------------------------------------

This isn't really about reading another plugin's config - in the release plugin's case, it reads and processes the entire POM as a file, not part of the current build. So I think this is ok - but you'll need to come up with a sensible way to detect it without hitting any false positives.

> Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-564
>                 URL: http://jira.codehaus.org/browse/MRELEASE-564
>             Project: Maven 2.x Release Plugin
>          Issue Type: Improvement
>          Components: prepare
>    Affects Versions: 2.0-beta-9
>            Reporter: Baptiste MATHUS
>            Priority: Critical
>
> Recently, I realized we rolled a released containing a reference onto a -SNAPSHOT version of our quality rules :/.
> This was because of the following remote-resources plugin configuration:
> {code:xml}
> <plugin>
>   <artifactId>maven-remote-resources-plugin</artifactId>
>   <version>1.1</version>
>   <executions>
>     <execution>
>       <goals>
>         <goal>process</goal>
>       </goals>
>       <configuration>
>         <resourceBundles>
>           <resourceBundle>fr.comp-shared-resources:1.0-SNAPSHOT</resourceBundle>
>         </resourceBundles>
>       </configuration>
>     </execution>
>   </executions>
> </plugin>
> {code}
> I think release:prepare should fail when it detects this.
> I seem to remember it's a bad practice to read other plugin's config, but I file this issue because:
> * remote-resources-plugin is a standard maven plugin, so I guess this use is to be often encountered
> * this is a very important issue and I'd like to file it somewhere. Please let me know if I should file or discuss it somewhere else.
> Cheers

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MRELEASE-564) Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration

Posted by "Baptiste MATHUS (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRELEASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236713#action_236713 ] 

Baptiste MATHUS commented on MRELEASE-564:
------------------------------------------

I'd like to try to take on this one, but I seem to remember it's a mojo bad practice to read other plugin's configuration.
But I don't see how to do it another way.

Any mojo developer hint?

Thanks

> Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-564
>                 URL: http://jira.codehaus.org/browse/MRELEASE-564
>             Project: Maven 2.x Release Plugin
>          Issue Type: Improvement
>          Components: prepare
>    Affects Versions: 2.0-beta-9
>            Reporter: Baptiste MATHUS
>            Priority: Critical
>
> Recently, I realized we rolled a released containing a reference onto a -SNAPSHOT version of our quality rules :/.
> This was because of the following remote-resources plugin configuration:
> {code:xml}
> <plugin>
>   <artifactId>maven-remote-resources-plugin</artifactId>
>   <version>1.1</version>
>   <executions>
>     <execution>
>       <goals>
>         <goal>process</goal>
>       </goals>
>       <configuration>
>         <resourceBundles>
>           <resourceBundle>fr.comp-shared-resources:1.0-SNAPSHOT</resourceBundle>
>         </resourceBundles>
>       </configuration>
>     </execution>
>   </executions>
> </plugin>
> {code}
> I think release:prepare should fail when it detects this.
> I seem to remember it's a bad practice to read other plugin's config, but I file this issue because:
> * remote-resources-plugin is a standard maven plugin, so I guess this use is to be often encountered
> * this is a very important issue and I'd like to file it somewhere. Please let me know if I should file or discuss it somewhere else.
> Cheers

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] (MRELEASE-564) Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration

Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MRELEASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=290235#comment-290235 ] 

Robert Scholte commented on MRELEASE-564:
-----------------------------------------

There might be another important plugin which needs to verify this: the {{maven-site-plugin}} since 3.0
So maybe we need a more general way to solve this. Something like a new interface for Mojo's which can provide a list of extra artifacts/dependencies.
                
> Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-564
>                 URL: https://jira.codehaus.org/browse/MRELEASE-564
>             Project: Maven 2.x Release Plugin
>          Issue Type: Improvement
>          Components: prepare
>    Affects Versions: 2.0-beta-9
>            Reporter: Baptiste MATHUS
>            Priority: Critical
>
> Recently, I realized we rolled a released containing a reference onto a -SNAPSHOT version of our quality rules :/.
> This was because of the following remote-resources plugin configuration:
> {code:xml}
> <plugin>
>   <artifactId>maven-remote-resources-plugin</artifactId>
>   <version>1.1</version>
>   <executions>
>     <execution>
>       <goals>
>         <goal>process</goal>
>       </goals>
>       <configuration>
>         <resourceBundles>
>           <resourceBundle>fr.comp-shared-resources:1.0-SNAPSHOT</resourceBundle>
>         </resourceBundles>
>       </configuration>
>     </execution>
>   </executions>
> </plugin>
> {code}
> I think release:prepare should fail when it detects this.
> I seem to remember it's a bad practice to read other plugin's config, but I file this issue because:
> * remote-resources-plugin is a standard maven plugin, so I guess this use is to be often encountered
> * this is a very important issue and I'd like to file it somewhere. Please let me know if I should file or discuss it somewhere else.
> Cheers

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira