You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/19 12:33:00 UTC
[jira] [Work logged] (BEAM-4318) Enforce ErrorProne analysis in
Spark runner project
[ https://issues.apache.org/jira/browse/BEAM-4318?focusedWorklogId=103662&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-103662 ]
ASF GitHub Bot logged work on BEAM-4318:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/18 12:32
Start Date: 19/May/18 12:32
Worklog Time Spent: 10m
Work Description: tengpeng opened a new pull request #5430: [BEAM-4318] Enforce ErrorProne analysis in Spark runner project
URL: https://github.com/apache/beam/pull/5430
This PR follows other PRs that fix the ErrorProne warnings.
Results:
```
./gradlew --no-build-cache :beam-runners-spark:cleanCompileJava :beam-runners-spark:cleanCompileTestJava :beam-runners-spark:assemble
Parallel execution with configuration on demand is an incubating feature.
> Configure project :
Applying build_rules.gradle to beam
createPerformanceTestHarness with default configuration for project beam
Adding 47 .gitignore exclusions to Apache Rat
> Configure project :beam-sdks-java-core
Applying build_rules.gradle to beam-sdks-java-core
applyJavaNature with [failOnWarning:true, shadowClosure:org.codehaus.groovy.runtime.ComposedClosure@677a279] for project beam-sdks-java-core
applyAvroNature with default configuration for project beam-sdks-java-core
> Configure project :beam-runners-spark
Applying build_rules.gradle to beam-runners-spark
applyJavaNature with [failOnWarning:true] for project beam-runners-spark
Generating :runQuickstartJavaSpark
> Configure project :beam-model-pipeline
Applying build_rules.gradle to beam-model-pipeline
applyJavaNature with [enableFindbugs:false, enableErrorProne:false] for project beam-model-pipeline
applyGrpcNature with default configuration for project beam-model-pipeline
> Configure project :beam-runners-core-construction-java
Applying build_rules.gradle to beam-runners-core-construction-java
applyJavaNature with default configuration for project beam-runners-core-construction-java
> Configure project :beam-runners-core-java
Applying build_rules.gradle to beam-runners-core-java
applyJavaNature with default configuration for project beam-runners-core-java
> Configure project :beam-sdks-java-io-kafka
Applying build_rules.gradle to beam-sdks-java-io-kafka
applyJavaNature with [enableFindbugs:false] for project beam-sdks-java-io-kafka
> Configure project :beam-model-job-management
Applying build_rules.gradle to beam-model-job-management
applyJavaNature with [enableFindbugs:false, enableErrorProne:false] for project beam-model-job-management
applyGrpcNature with default configuration for project beam-model-job-management
> Configure project :beam-model-fn-execution
Applying build_rules.gradle to beam-model-fn-execution
applyJavaNature with [enableFindbugs:false, enableErrorProne:false] for project beam-model-fn-execution
applyGrpcNature with default configuration for project beam-model-fn-execution
> Task :beam-runners-spark:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :beam-runners-spark:compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
See https://docs.gradle.org/4.7/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 15s
39 actionable tasks: 3 executed, 36 up-to-date
```
Special thanks to @swegner for his help :P
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 103662)
Time Spent: 10m
Remaining Estimate: 0h
> Enforce ErrorProne analysis in Spark runner project
> ---------------------------------------------------
>
> Key: BEAM-4318
> URL: https://issues.apache.org/jira/browse/BEAM-4318
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Scott Wegner
> Priority: Minor
> Labels: errorprone, starter
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently enabled|https://github.com/apache/beam/pull/5161] in the Gradle build process, but only as warnings. ErrorProne errors are generally useful and easy to fix. Some work was done to [make sdks-java-core ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add enforcement. This task is clean ErrorProne warnings and add enforcement in {{beam-runners-spark}}. Additional context discussed on the [dev list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development environment.
> # Run the following command to compile and run ErrorProne analysis on the project: {{./gradlew :beam-runners-spark:assemble}}
> # Fix each ErrorProne warning from the {{runners/spark}} project.
> # In {{runners/spark/build.gradle}}, add {{failOnWarning: true}} to the call the {{applyJavaNature()}} ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach out|https://beam.apache.org/community/contact-us/] with questions or code review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)