You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:36:46 UTC
[GitHub] [airflow] ljb7977 opened a new issue #9021: Glue sensor runs indefinitely after the Glue job is finished
ljb7977 opened a new issue #9021:
URL: https://github.com/apache/airflow/issues/9021
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
This questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**: 1.10.10 (master has same issue)
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`): N/A
**Environment**:
- **Cloud provider or hardware configuration**:
- **OS** (e.g. from /etc/os-release): MacOS 10.15.4
- **Kernel** (e.g. `uname -a`): Darwin Kernel Version 19.4.0
- **Install tools**: pip
- **Others**:
**What happened**:
<!-- (please include exact error messages if you can) -->
**What you expected to happen**:
There is a mismatch between [return value](https://github.com/apache/airflow/blob/9764c90b925a710506f43423302f3fa512490c03/airflow/providers/amazon/aws/hooks/glue.py#L133) of `job_completion` of AwsGlueJobHook and [end condition](https://github.com/apache/airflow/blob/9764c90b925a710506f43423302f3fa512490c03/airflow/providers/amazon/aws/sensors/glue.py#L58) in `poke` of AwsGlueJobSensor. While `job_completion` returns a dictionary of JobRunState and JobRunId, `poke` checks if it is 'SUCCEEDED' or 'FAILED' which should be only JobRunState. So the condition always fails and `poke` always returns False which leads GlueSensor to run indefinitely even if Glue job finished.
Also, I think while loop in `job_completion` is useless. It should return immediately after it gets response from glue client but doesn't have to wait until it finishes or fails. It is duplicated with execution loop of Sensor.
**How to reproduce it**:
Run any job and wait for the job using GlueJobSensor.
**Anything else we need to know**:
<!--
How often does this problem occur? Once? Every time etc?
Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #9021: Glue sensor runs indefinitely after the Glue job is finished
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #9021:
URL: https://github.com/apache/airflow/issues/9021#issuecomment-634052587
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle closed issue #9021: Glue sensor runs indefinitely after the Glue job is finished
Posted by GitBox <gi...@apache.org>.
feluelle closed issue #9021:
URL: https://github.com/apache/airflow/issues/9021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org