You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/08/17 11:24:07 UTC
[GitHub] [james-project] chibenwa opened a new pull request #603: JAMES-3440 JMAP RFC-8621: EmailQueryView position handling was wrong
chibenwa opened a new pull request #603:
URL: https://github.com/apache/james-project/pull/603
Cc @Arsnael
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #603: JAMES-3440 JMAP RFC-8621: EmailQueryView position handling was wrong
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #603:
URL: https://github.com/apache/james-project/pull/603#discussion_r690900816
##########
File path: server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailQueryMethod.scala
##########
@@ -109,7 +109,7 @@ class EmailQueryMethod @Inject() (serializer: EmailQuerySerializer,
val after: ZonedDateTime = condition.after.get.asUTC
SMono(mailboxManager.getMailboxReactive(mailboxId, mailboxSession))
.`then`(SFlux.fromPublisher(
- emailQueryView.listMailboxContentSinceReceivedAt(mailboxId, after, JavaLimit.from(limitToUse.value)))
+ emailQueryView.listMailboxContentSinceReceivedAt(mailboxId, after, JavaLimit.from(limitToUse.value + position.value)))
Review comment:
No addition, because after that we `skip` position elements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a change in pull request #603: JAMES-3440 JMAP RFC-8621: EmailQueryView position handling was wrong
Posted by GitBox <gi...@apache.org>.
vttranlina commented on a change in pull request #603:
URL: https://github.com/apache/james-project/pull/603#discussion_r690883502
##########
File path: server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailQueryMethod.scala
##########
@@ -109,7 +109,7 @@ class EmailQueryMethod @Inject() (serializer: EmailQuerySerializer,
val after: ZonedDateTime = condition.after.get.asUTC
SMono(mailboxManager.getMailboxReactive(mailboxId, mailboxSession))
.`then`(SFlux.fromPublisher(
- emailQueryView.listMailboxContentSinceReceivedAt(mailboxId, after, JavaLimit.from(limitToUse.value)))
+ emailQueryView.listMailboxContentSinceReceivedAt(mailboxId, after, JavaLimit.from(limitToUse.value + position.value)))
Review comment:
Should be `multiplication`? (Not `addition`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #603: JAMES-3440 JMAP RFC-8621: EmailQueryView position handling was wrong
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #603:
URL: https://github.com/apache/james-project/pull/603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #603: JAMES-3440 JMAP RFC-8621: EmailQueryView position handling was wrong
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #603:
URL: https://github.com/apache/james-project/pull/603#discussion_r690900816
##########
File path: server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailQueryMethod.scala
##########
@@ -109,7 +109,7 @@ class EmailQueryMethod @Inject() (serializer: EmailQuerySerializer,
val after: ZonedDateTime = condition.after.get.asUTC
SMono(mailboxManager.getMailboxReactive(mailboxId, mailboxSession))
.`then`(SFlux.fromPublisher(
- emailQueryView.listMailboxContentSinceReceivedAt(mailboxId, after, JavaLimit.from(limitToUse.value)))
+ emailQueryView.listMailboxContentSinceReceivedAt(mailboxId, after, JavaLimit.from(limitToUse.value + position.value)))
Review comment:
No addition, because after that we `skip` position elements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a change in pull request #603: JAMES-3440 JMAP RFC-8621: EmailQueryView position handling was wrong
Posted by GitBox <gi...@apache.org>.
vttranlina commented on a change in pull request #603:
URL: https://github.com/apache/james-project/pull/603#discussion_r690883502
##########
File path: server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailQueryMethod.scala
##########
@@ -109,7 +109,7 @@ class EmailQueryMethod @Inject() (serializer: EmailQuerySerializer,
val after: ZonedDateTime = condition.after.get.asUTC
SMono(mailboxManager.getMailboxReactive(mailboxId, mailboxSession))
.`then`(SFlux.fromPublisher(
- emailQueryView.listMailboxContentSinceReceivedAt(mailboxId, after, JavaLimit.from(limitToUse.value)))
+ emailQueryView.listMailboxContentSinceReceivedAt(mailboxId, after, JavaLimit.from(limitToUse.value + position.value)))
Review comment:
Should be `multiplication`? (Not `addition`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org