[GitHub] xuanyuanking commented on a change in pull request #23327: [SPARK-26222][SQL] Track file listing time

[GitBox <gi...@apache.org>]

xuanyuanking commented on a change in pull request #23327: [SPARK-26222][SQL] Track file listing time
URL: https://github.com/apache/spark/pull/23327#discussion_r242026087
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
 ##########
 @@ -313,8 +321,10 @@ case class FileSourceScanExec(
   override lazy val metrics =
     Map("numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output rows"),
       "numFiles" -> SQLMetrics.createMetric(sparkContext, "number of files"),
+      "scanTime" -> SQLMetrics.createTimingMetric(sparkContext, "scan time"),
       "fileListingTime" -> SQLMetrics.createMetric(sparkContext, "file listing time (ms)"),
 
 Review comment:
   Currently, the file listing time still contains part of partition pruning time(introduced from [SPARK-20151](https://github.com/apache/spark/pull/17476/files)), I think we should split the partition pruning time into `metastore operation time`, which will be done in https://issues.apache.org/jira/browse/SPARK-26223.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org