You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/11 13:18:57 UTC

[GitHub] [flink] githubMJ opened a new pull request #15894: [FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is…

githubMJ opened a new pull request #15894:
URL: https://github.com/apache/flink/pull/15894


   > ## What is the purpose of the change
   > 
   > Flink Table Enventment Parsr Hive Drop Partitions Syntax unparse is Error
   > 
   > ## Brief change log
   > * Flink Table Parser is error Synopsis:
   > * SQL：
   > `alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);`
   > * Hive Multiple partitions unparse toSqlString is error,Missing comma in Partition SqlNodeList 
   > * In Flink Table Hive Env syntax：
   > `ALTER TABLE tbl
         DROP
         PARTITION (`P1` = 'a', `P2` = 1)
         PARTITION (`P1` = 'b', `P2` = 2)`
   
   >  * The right hive syntax ：
   >`ALTER TABLE tbl
         DROP
         PARTITION (`P1` = 'a', `P2` = 1),
         PARTITION (`P1` = 'b', `P2` = 2)`
   > ## Verifying this change
   > This change is a trivial rework / code cleanup without any test coverage.
   > 
   > ## Does this pull request potentially affect one of the following parts:
   > * Dependencies (does it add or upgrade a dependency): no
   > * The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
   > * The serializers: no
   > * The runtime per-record code paths (performance sensitive): no
   > * Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
   > * The S3 file system connector: no
   > 
   > ## Documentation
   > * Does this pull request introduce a new feature? no
   > * If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15894: [FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #15894:
URL: https://github.com/apache/flink/pull/15894#issuecomment-838510393


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "379dab9e8987493f5332646e0799ea6c2355c825",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17867",
       "triggerID" : "379dab9e8987493f5332646e0799ea6c2355c825",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 379dab9e8987493f5332646e0799ea6c2355c825 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17867) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15894: [FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #15894:
URL: https://github.com/apache/flink/pull/15894#issuecomment-838462751

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 379dab9e8987493f5332646e0799ea6c2355c825 (Sat Aug 28 11:21:07 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] githubMJ edited a comment on pull request #15894: [FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is…

Posted by GitBox <gi...@apache.org>.

githubMJ edited a comment on pull request #15894:
URL: https://github.com/apache/flink/pull/15894#issuecomment-839588069


   @lirui-apache need merge, please reviewer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15894: [FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #15894:
URL: https://github.com/apache/flink/pull/15894#issuecomment-838510393


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "379dab9e8987493f5332646e0799ea6c2355c825",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17867",
       "triggerID" : "379dab9e8987493f5332646e0799ea6c2355c825",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 379dab9e8987493f5332646e0799ea6c2355c825 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17867) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15894: [FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #15894:
URL: https://github.com/apache/flink/pull/15894#issuecomment-838462751

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 379dab9e8987493f5332646e0799ea6c2355c825 (Tue May 11 13:21:22 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] githubMJ commented on pull request #15894: [FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is…

Posted by GitBox <gi...@apache.org>.

githubMJ commented on pull request #15894:
URL: https://github.com/apache/flink/pull/15894#issuecomment-839588069


   @lirui-apache need merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lirui-apache closed pull request #15894: [FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is…

Posted by GitBox <gi...@apache.org>.

lirui-apache closed pull request #15894:
URL: https://github.com/apache/flink/pull/15894


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15894: [FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #15894:
URL: https://github.com/apache/flink/pull/15894#issuecomment-838510393


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "379dab9e8987493f5332646e0799ea6c2355c825",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "379dab9e8987493f5332646e0799ea6c2355c825",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 379dab9e8987493f5332646e0799ea6c2355c825 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org