You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/07/20 15:33:44 UTC
[GitHub] [incubator-kyuubi] timothy65535 opened a new pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
timothy65535 opened a new pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843
Fixes #842
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### 1. Describe the bug
Meet rat check error when build kyuubi project
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (default-cli) on project kyuubi: Too many files with unapproved license: 75 See RAT report in: /work/projects/opensource/kyuubi/target/rat.txt -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
```
### 2. Steps to reproduce
1. Build kyuubi project
```
./build/dist --tgz --spark-provided -Pkyuubi-extension-spark_3.1
```
2. Untar dist package and check some jars
3. Build kyuubi again
### _How was this patch tested?_
- [X] Add some test cases that check the changes thoroughly including negative and positive cases if possible
```
mvn org.apache.rat:apache-rat-plugin:0.13:check
```
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#discussion_r673261077
##########
File path: pom.xml
##########
@@ -1371,6 +1371,8 @@
<exclude>build/scala-*/**</exclude>
<exclude>**/**/operation_logs/**/**</exclude>
<exclude>**/*.output.schema</exclude>
+ <exclude>kyuubi-*-bin-without-spark/**</exclude>
+ <exclude>kyuubi-*-bin-spark-*/**</exclude>
Review comment:
we can merge them to `kyuubi-*-bin-*/**`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#issuecomment-883518901
> I don't think we need to exclude files added manually.
+1. The `./build/dist` without `--tgz` will output to `dist`, which excluded by rat. The unarchived folder is out of the scope.
> Maybe we shall add a LICENSE head to `kyuubi-1.3.0-SNAPSHOT-bin-without-spark/RELEASE`
Spark also does not add LICENSE head in RELEASE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] timothy65535 commented on pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
timothy65535 commented on pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#issuecomment-883812177
Add `**` as prefix, it suits more scenarios.
```
<exclude>**/kyuubi-*-bin-without-spark/**</exclude>
<exclude>**/kyuubi-*-bin-spark-*/**</exclude>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#issuecomment-883811423
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/843?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#843](https://codecov.io/gh/apache/incubator-kyuubi/pull/843?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcec9b1) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7ee92ce5c1831fa20e62c1a703fd0564416f75cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ee92ce) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head bcec9b1 differs from pull request most recent head a236167. Consider uploading reports for the commit a236167 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #843 +/- ##
=========================================
Coverage 78.60% 78.60%
Complexity 10 10
=========================================
Files 135 135
Lines 5122 5122
Branches 641 641
=========================================
Hits 4026 4026
Misses 745 745
Partials 351 351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/843?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/843?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7ee92ce...a236167](https://codecov.io/gh/apache/incubator-kyuubi/pull/843?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#issuecomment-883521423
`-without-spark` can be ommited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#issuecomment-883498100
I don't think we need to exclude files added manually.
Maybe we shall add a LICENSE head to `kyuubi-1.3.0-SNAPSHOT-bin-without-spark/RELEASE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#issuecomment-883520769
> > I don't think we need to exclude files added manually.
>
> +1. The `./build/dist` without `--tgz` will output to `dist`, which excluded by rat. The unarchived folder is out of the scope.
>
> > Maybe we shall add a LICENSE head to `kyuubi-1.3.0-SNAPSHOT-bin-without-spark/RELEASE`
>
> Spark also does not add LICENSE head in RELEASE.
Can we check other Apache Incubating Projects which have some releases came out. The Apache Policy is evolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#issuecomment-883531399
Have not seen another project that has a RELEASE file in binary dist. It should be acceptable that some doc files like `CHANGELOG.md` `README.md` dist without licence head. (ref: Skywalking)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn edited a comment on pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#issuecomment-883521423
`-without-spark` can be omited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn edited a comment on pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#issuecomment-883521423
`-without-spark` can be ommited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #843: [KYUUBI #842] Fix meet rat check error when build kyuubi project
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #843:
URL: https://github.com/apache/incubator-kyuubi/pull/843#issuecomment-883874755
thanks, merging to master for v1.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org