(superset) branch test-drivers-sqlalchemy2-ranges created (now a2c4b3ab19c)

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aminghadersohi pushed a change to branch test-drivers-sqlalchemy2-ranges
in repository https://gitbox.apache.org/repos/asf/superset.git


      at a2c4b3ab19c test(presto): reword dialect test docstring to match what it pins

This branch includes the following new commits:

     new a2c4b3ab19c test(presto): reword dialect test docstring to match what it pins

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

(superset) 01/01: test(presto): reword dialect test docstring to match what it pins

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aminghadersohi pushed a commit to branch test-drivers-sqlalchemy2-ranges
in repository https://gitbox.apache.org/repos/asf/superset.git

commit a2c4b3ab19c6e03e15e4d1090d0560c0aace7d9a
Author: Amin Ghadersohi <am...@gmail.com>
AuthorDate: Fri Sep 18 01:47:54 2026 +0000

    test(presto): reword dialect test docstring to match what it pins
    
    The docstring claimed the test guarded the PyHive 0.6.5 / SQLAlchemy 2
    version floor, which it cannot do: PrestoDialect is imported at module
    scope, so an incompatible PyHive errors the module during collection
    before any test body runs. Reword to describe what the test actually
    pins: presto:// entry point resolution and the pyformat paramstyle.
---
 tests/unit_tests/db_engine_specs/test_presto.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit_tests/db_engine_specs/test_presto.py b/tests/unit_tests/db_engine_specs/test_presto.py
index 9808aff5325..0fb7e207e7f 100644
--- a/tests/unit_tests/db_engine_specs/test_presto.py
+++ b/tests/unit_tests/db_engine_specs/test_presto.py
@@ -47,7 +47,7 @@ from tests.unit_tests.db_engine_specs.utils import (
 
 
 def test_dialect_loads_under_installed_sqlalchemy(mocker: MockerFixture) -> None:
-    """Load the real dialect without connecting; PyHive 0.6.5 fails on SQLAlchemy 2."""
+    """Pin presto:// entry point resolution and the pyformat paramstyle, without I/O."""
     socket = mocker.patch("socket.socket", side_effect=AssertionError("Network I/O"))
     engine = create_engine("presto://user@localhost:8080/hive/default")
     try: