[jira] [Commented] (TEZ-807) Build broken due to NPE

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894000#comment-13894000 ] 

Siddharth Seth commented on TEZ-807:
------------------------------------

Nit: In Vertex, setTaskLocalResources - the map is recreated, it could just be cleared instead.

There's checks in several places on taskResoruces / env being null - should remove them since they're not required any more. I don't think serialization in teh DAG plan is affected by this change, so that should just work as is.

Otherwise, looks good to me.

> Build broken due to NPE
> -----------------------
>
>                 Key: TEZ-807
>                 URL: https://issues.apache.org/jira/browse/TEZ-807
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Gunther Hagleitner
>            Assignee: Gunther Hagleitner
>            Priority: Blocker
>         Attachments: TEZ-807.1.patch
>
>
> testThreeLevelsFailingDAGSuccess(org.apache.tez.test.TestFaultTolerance)  Time elapsed: 0.055 sec  <<< ERROR!
> java.lang.NullPointerException: null
>         at org.apache.tez.client.TezClientUtils.setupDAGCredentials(TezClientUtils.java:278)
>         at org.apache.tez.client.TezSession.submitDAG(TezSession.java:149)
>         at org.apache.tez.test.TestFaultTolerance.runDAGAndVerify(TestFaultTolerance.java:121)
>         at org.apache.tez.test.TestFaultTolerance.testThreeLevelsFailingDAGSuccess(TestFaultTolerance.java:276)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)