You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jackye1995 (via GitHub)" <gi...@apache.org> on 2023/04/26 20:47:24 UTC
[GitHub] [iceberg] jackye1995 opened a new issue, #7440: Simplify JDK build versions using --release flag
jackye1995 opened a new issue, #7440:
URL: https://github.com/apache/iceberg/issues/7440
### Feature Request / Improvement
Currently we run CI for each JDK version (8, 11, 17). As discussed on devlist https://lists.apache.org/thread/hr7rdxvddw3fklfyg3dfbqbsy81hzhyk, it is unlikely for Iceberg to move to higher Java versions because of upstream dependency.
However, we could technically use the highest version of Java to build, and use `--release` flag to enforce that it uses only JDK8 language features.
This requires changes in the gradle build, CI configurations and release script configurations.
Once it is done, we can run all CIs directly in the latest JDK version, and be confident that it won't break JDK8.
### Query engine
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] laurentgo commented on issue #7440: Simplify JDK build versions using --release flag
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on issue #7440:
URL: https://github.com/apache/iceberg/issues/7440#issuecomment-1572466955
We can choose to default to 17 for the build, but hive would still need to use java 8 to at least run tests, and we may also want to run tests in general with Java 8 as a compatibility measure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Simplify JDK build versions using --release flag [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #7440: Simplify JDK build versions using --release flag
URL: https://github.com/apache/iceberg/issues/7440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Simplify JDK build versions using --release flag [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7440:
URL: https://github.com/apache/iceberg/issues/7440#issuecomment-1858628332
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on issue #7440: Simplify JDK build versions using --release flag
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on issue #7440:
URL: https://github.com/apache/iceberg/issues/7440#issuecomment-1570575602
In that case, feels like we could technically already remove all the DJK8 CIs and default to just run on JDK11 or 17? Is everyone good with that? @aokolnychyi @flyrain @boroknagyz @amogh-jahagirdar @laurentgo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on issue #7440: Simplify JDK build versions using --release flag
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on issue #7440:
URL: https://github.com/apache/iceberg/issues/7440#issuecomment-1568774184
> What is the preferred approach here: keep using the palantir plugin or making --release explicit?
I guess it depends on if we can leverage the palantir plugin to achieve what we want, which is to run build with only JDK11/17, but have `--release` as 8.
You say that the `--release` flag is introduced based on `sourceCompatibility` and `targetCompatibility`, can we manipulate those 2 configs to achieve the goal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] laurentgo commented on issue #7440: Simplify JDK build versions using --release flag
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on issue #7440:
URL: https://github.com/apache/iceberg/issues/7440#issuecomment-1568713358
In my local testing, I discovered that the palantir `release-compatibility` plugin would actually introduce `--release` flag based on `sourceCompatibility` and `targetCompatibility`, which means that in practice JDK 11 and JDK 17 builds are actually compatible with Java8.
Adding `--release` via `CompilerOptions` would actually result in a conflict.
What is the preferred approach here: keep using the `palantir` plugin or making `--release` explicit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Simplify JDK build versions using --release flag [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7440:
URL: https://github.com/apache/iceberg/issues/7440#issuecomment-1835009496
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] laurentgo commented on issue #7440: Simplify JDK build versions using --release flag
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on issue #7440:
URL: https://github.com/apache/iceberg/issues/7440#issuecomment-1569114201
> You say that the --release flag is introduced based on sourceCompatibility and targetCompatibility, can we manipulate those 2 configs to achieve the goal?
It's actually what is happening today. We set the value [here](https://github.com/apache/iceberg/blob/ee1040e50437f604934fb87addbae11b40073fef/build.gradle#L211), and the plugin add `--release 8` accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on issue #7440: Simplify JDK build versions using --release flag
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on issue #7440:
URL: https://github.com/apache/iceberg/issues/7440#issuecomment-1573221542
when you say Hive, do you mean any tests involving Hive metastore, or just `iceberg-hive3` tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org