You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/09/10 23:34:01 UTC
[kudu-CR] [jepsen] a bunch of minor updates on README.adoc
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11414
Change subject: [jepsen] a bunch of minor updates on README.adoc
......................................................................
[jepsen] a bunch of minor updates on README.adoc
Added a link to the reference script for building Kudu and running
Jepsen tests. Added information on how to quickly locate corresponding
sections in the Jepsen output in case if an error happened during Jepsen
tests run. Updated the command to build the kudu-jepnsen package.
This patch does not contain any functional changes.
Change-Id: Ibd4c7a522829e774f786a85d4bdfa01d0be553f5
---
M java/kudu-jepsen/README.adoc
1 file changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/11414/1
--
To view, visit http://gerrit.cloudera.org:8080/11414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd4c7a522829e774f786a85d4bdfa01d0be553f5
Gerrit-Change-Number: 11414
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [jepsen] a bunch of minor updates on README.adoc
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11414 )
Change subject: [jepsen] a bunch of minor updates on README.adoc
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd4c7a522829e774f786a85d4bdfa01d0be553f5
Gerrit-Change-Number: 11414
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 11 Sep 2018 04:41:37 +0000
Gerrit-HasComments: No
[kudu-CR] [jepsen] a bunch of minor updates on README.adoc
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11414 )
Change subject: [jepsen] a bunch of minor updates on README.adoc
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11414/1/java/kudu-jepsen/README.adoc
File java/kudu-jepsen/README.adoc:
http://gerrit.cloudera.org:8080/#/c/11414/1/java/kudu-jepsen/README.adoc@143
PS1, Line 143: `^ERROR -in\(` regex pattern
Can you please add an example of such error message?
--
To view, visit http://gerrit.cloudera.org:8080/11414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd4c7a522829e774f786a85d4bdfa01d0be553f5
Gerrit-Change-Number: 11414
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 11 Sep 2018 01:04:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] [jepsen] a bunch of minor updates on README.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11414 )
Change subject: [jepsen] a bunch of minor updates on README.adoc
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11414/1/java/kudu-jepsen/README.adoc
File java/kudu-jepsen/README.adoc:
http://gerrit.cloudera.org:8080/#/c/11414/1/java/kudu-jepsen/README.adoc@143
PS1, Line 143: `^ERROR -in\(` regex pattern
> Can you please add an example of such error message?
Done
--
To view, visit http://gerrit.cloudera.org:8080/11414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd4c7a522829e774f786a85d4bdfa01d0be553f5
Gerrit-Change-Number: 11414
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 11 Sep 2018 01:42:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [jepsen] a bunch of minor updates on README.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11414
to look at the new patch set (#2).
Change subject: [jepsen] a bunch of minor updates on README.adoc
......................................................................
[jepsen] a bunch of minor updates on README.adoc
Added a link to the reference script for building Kudu and running
Jepsen tests. Added information on how to quickly locate corresponding
sections in the Jepsen output in case if an error happened during Jepsen
tests run. Updated the command to build the kudu-jepnsen package.
This patch does not contain any functional changes.
Change-Id: Ibd4c7a522829e774f786a85d4bdfa01d0be553f5
---
M java/kudu-jepsen/README.adoc
1 file changed, 19 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/11414/2
--
To view, visit http://gerrit.cloudera.org:8080/11414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibd4c7a522829e774f786a85d4bdfa01d0be553f5
Gerrit-Change-Number: 11414
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [jepsen] a bunch of minor updates on README.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11414 )
Change subject: [jepsen] a bunch of minor updates on README.adoc
......................................................................
[jepsen] a bunch of minor updates on README.adoc
Added a link to the reference script for building Kudu and running
Jepsen tests. Added information on how to quickly locate corresponding
sections in the Jepsen output in case if an error happened during Jepsen
tests run. Updated the command to build the kudu-jepnsen package.
This patch does not contain any functional changes.
Change-Id: Ibd4c7a522829e774f786a85d4bdfa01d0be553f5
Reviewed-on: http://gerrit.cloudera.org:8080/11414
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M java/kudu-jepsen/README.adoc
1 file changed, 19 insertions(+), 5 deletions(-)
Approvals:
Kudu Jenkins: Verified
Hao Hao: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd4c7a522829e774f786a85d4bdfa01d0be553f5
Gerrit-Change-Number: 11414
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins