You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Bruno Peeters (JIRA)" <ji...@apache.org> on 2009/02/02 16:39:59 UTC
[jira] Created: (JSPWIKI-487) Bread crumbs and renamed and deleted
pages
Bread crumbs and renamed and deleted pages
------------------------------------------
Key: JSPWIKI-487
URL: https://issues.apache.org/jira/browse/JSPWIKI-487
Project: JSPWiki
Issue Type: Bug
Affects Versions: 2.8.1
Reporter: Bruno Peeters
Priority: Minor
Pages that are renamed or deleted remain in the list of pages visited (the bread crumbs).
If a users clicks on such a page, he receives a message that the page does not exists and is asked to create the page.
It would be more user friendly if renamed and deleted pages would be removed from the list of visited sites.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-487) Bread crumbs and renamed and
deleted pages
Posted by "Wouter Van daele (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683613#action_12683613 ]
Wouter Van daele commented on JSPWIKI-487:
------------------------------------------
Harry,
I applied your patch to a version of 2.8.2. Renaming is OK, but 'Delete.jsp' needs a little adjustment to be effective: replace this line 51
response.sendRedirect(wiki.getViewURL(redirTo));
by this line
response.sendRedirect( wikiContext.getURL( WikiContext.VIEW, pagereq ) );
and it works - most of the time ;-)
Why the "most of the time"? When having multiple consecutive entries for the same page in the breadcrumbs trail, not all of them are deleted. Could be a problem in the 'removeItem' method of the FixedQueue class, but I haven't had time to figure that out yet...
W.
> Bread crumbs and renamed and deleted pages
> ------------------------------------------
>
> Key: JSPWIKI-487
> URL: https://issues.apache.org/jira/browse/JSPWIKI-487
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Attachments: JSPWiki-487-2.8.patch, JSPWiki-487-3.0.patch
>
>
> Pages that are renamed or deleted remain in the list of pages visited (the bread crumbs).
> If a users clicks on such a page, he receives a message that the page does not exists and is asked to create the page.
> It would be more user friendly if renamed and deleted pages would be removed from the list of visited sites.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-487) Bread crumbs and renamed and
deleted pages
Posted by "Wouter Van daele (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683849#action_12683849 ]
Wouter Van daele commented on JSPWIKI-487:
------------------------------------------
"Could be a problem in the 'removeItem' method of the FixedQueue class, but I haven't had time to figure that out yet..." - No, that's not it.
When you delete two wikipages one after the other, that's when the name of the first one you deleted still remains in the breadcrumbs. I presume this is because when changing pages there is no check to see if the page you just visited actually exists...
> Bread crumbs and renamed and deleted pages
> ------------------------------------------
>
> Key: JSPWIKI-487
> URL: https://issues.apache.org/jira/browse/JSPWIKI-487
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Attachments: JSPWiki-487-2.8.patch, JSPWiki-487-3.0.patch
>
>
> Pages that are renamed or deleted remain in the list of pages visited (the bread crumbs).
> If a users clicks on such a page, he receives a message that the page does not exists and is asked to create the page.
> It would be more user friendly if renamed and deleted pages would be removed from the list of visited sites.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-487) Bread crumbs and renamed and
deleted pages
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683982#action_12683982 ]
Harry Metske commented on JSPWIKI-487:
--------------------------------------
The funny thing was that this check for deleted pages is in the 3.0 patch, but not in the 2.8 patch (now it is).
So, fixed in 2.8.2-svn-15
I'd like some review (from Andrew ?) whether the 3.0 patch is in the right place before committing that one.
> Bread crumbs and renamed and deleted pages
> ------------------------------------------
>
> Key: JSPWIKI-487
> URL: https://issues.apache.org/jira/browse/JSPWIKI-487
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Attachments: JSPWiki-487-2.8.patch, JSPWiki-487-3.0.patch
>
>
> Pages that are renamed or deleted remain in the list of pages visited (the bread crumbs).
> If a users clicks on such a page, he receives a message that the page does not exists and is asked to create the page.
> It would be more user friendly if renamed and deleted pages would be removed from the list of visited sites.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (JSPWIKI-487) Bread crumbs and renamed and deleted
pages
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske closed JSPWIKI-487.
--------------------------------
Resolution: Fixed
Also fixed in 3.0.0-svn-89
> Bread crumbs and renamed and deleted pages
> ------------------------------------------
>
> Key: JSPWIKI-487
> URL: https://issues.apache.org/jira/browse/JSPWIKI-487
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Assignee: Harry Metske
> Priority: Minor
> Attachments: JSPWiki-487-2.8.patch, JSPWiki-487-3.0.patch
>
>
> Pages that are renamed or deleted remain in the list of pages visited (the bread crumbs).
> If a users clicks on such a page, he receives a message that the page does not exists and is asked to create the page.
> It would be more user friendly if renamed and deleted pages would be removed from the list of visited sites.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-487) Bread crumbs and renamed and deleted
pages
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske updated JSPWIKI-487:
---------------------------------
Attachment: JSPWiki-487-3.0.patch
JSPWiki-487-2.8.patch
Attached two proposal patches.
FixedQueue gets an additional removeItem() method.
This method is called by Delete.jsp and Rename.jsp (2.8) , and DeleteActionBean and RenameActionBean (3.0), I added a new method deleteFromBreadCrumb() to AbstractPageActionBean, not sure if this is the correct place though.
> Bread crumbs and renamed and deleted pages
> ------------------------------------------
>
> Key: JSPWIKI-487
> URL: https://issues.apache.org/jira/browse/JSPWIKI-487
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 2.8.1
> Reporter: Bruno Peeters
> Priority: Minor
> Attachments: JSPWiki-487-2.8.patch, JSPWiki-487-3.0.patch
>
>
> Pages that are renamed or deleted remain in the list of pages visited (the bread crumbs).
> If a users clicks on such a page, he receives a message that the page does not exists and is asked to create the page.
> It would be more user friendly if renamed and deleted pages would be removed from the list of visited sites.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.