You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/05/07 02:00:42 UTC

[GitHub] [openwhisk-deploy-kube] dgrove-oss opened a new pull request #600: docs fix: Helm v3 doesn't automatically create the target namespace

dgrove-oss opened a new pull request #600:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/600


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] wkk edited a comment on pull request #600: docs fix: Helm v3 doesn't automatically create the target namespace

Posted by GitBox <gi...@apache.org>.
wkk edited a comment on pull request #600:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/600#issuecomment-632702651


   There is a new option in helm v3.2.0: `--create-namespace` which allow helm 3 to create the namespace if it doesn't exist (like the default behavior in helm 2)
   
   The PR that added this option:
   https://github.com/helm/helm/pull/7648
   
   Using this option we can still deploy using a single command:
   
   ```shell
   helm install owdev ./helm/openwhisk -f mycluster.yaml -n openwhisk --create-namespace
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] rabbah commented on a change in pull request #600: docs fix: Helm v3 doesn't automatically create the target namespace

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #600:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/600#discussion_r421201491



##########
File path: README.md
##########
@@ -230,7 +230,12 @@ For simplicity, in this README, we have used `owdev` as the release name and
 You can use a different name and/or namespace simply by changing the commands
 used below.
 
-Deployment can be done by using the following single command:
+First, create the target namespace for your OpenWhisk deployment:
+```shell
+kubectl create namespace openwhisk
+```
+
+Next, deploy openwhisk to that namespace:

Review comment:
       ```suggestion
   Next, deploy OpenWhisk to that namespace:
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on pull request #600: docs fix: Helm v3 doesn't automatically create the target namespace

Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #600:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/600#issuecomment-646029969


   I changed to use @wkk suggestion of adding `--create-namespace` to a single command line.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] dgrove-oss merged pull request #600: docs fix: Helm v3 doesn't automatically create the target namespace

Posted by GitBox <gi...@apache.org>.
dgrove-oss merged pull request #600:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/600


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-deploy-kube] wkk commented on pull request #600: docs fix: Helm v3 doesn't automatically create the target namespace

Posted by GitBox <gi...@apache.org>.
wkk commented on pull request #600:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/600#issuecomment-632702651


   There is a new option in helm v3.2.0: `--create-namespace` which allow helm 3 to create the namespace if it doesn't exist (like the default behavior in helm 2)
   
   The PR that added this option:
   https://github.com/helm/helm/pull/7648
   
   Using this command we can still deploy using a single command:
   
   ```shell
   helm install owdev ./helm/openwhisk -f mycluster.yaml -n openwhisk --create-namespace
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org