[GitHub] [kafka] jsancio commented on a diff in pull request #12981: MINOR: Pass snapshot ID directly in `RaftClient.createSnapshot`

[GitBox <gi...@apache.org>]

jsancio commented on code in PR #12981:
URL: https://github.com/apache/kafka/pull/12981#discussion_r1046477051


##########
raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java:
##########
@@ -32,7 +32,7 @@
  * topic partition from offset 0 up to but not including the end offset in the snapshot
  * id.
  *
- * @see org.apache.kafka.raft.KafkaRaftClient#createSnapshot(long, int, long)
+ * @see org.apache.kafka.raft.KafkaRaftClient#createSnapshot(OffsetAndEpoch, long)

Review Comment:
   Maybe this to point to `RaftClient.createSnapshot` since that is what we documented.
   ```
    * @see org.apache.kafka.raft.RaftClient#createSnapshot(OffsetAndEpoch, long)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org