You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by cp...@apache.org on 2016/01/04 13:19:39 UTC
svn commit: r1722856 - in /lucene/dev/trunk/lucene: CHANGES.txt
analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymFilterFactory.java
Author: cpoerschke
Date: Mon Jan 4 12:19:38 2016
New Revision: 1722856
URL: http://svn.apache.org/viewvc?rev=1722856&view=rev
Log:
LUCENE-6949: fix (potential) resource leak in SynonymFilterFactory (https://scan.coverity.com/projects/5620 CID 120656)
Modified:
lucene/dev/trunk/lucene/CHANGES.txt
lucene/dev/trunk/lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymFilterFactory.java
Modified: lucene/dev/trunk/lucene/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/CHANGES.txt?rev=1722856&r1=1722855&r2=1722856&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/CHANGES.txt (original)
+++ lucene/dev/trunk/lucene/CHANGES.txt Mon Jan 4 12:19:38 2016
@@ -214,6 +214,10 @@ Other
* LUCENE-6945: factor out TestCorePlus(Queries|Extensions)Parser from
TestParser, rename TestParser to TestCoreParser (Christine Poerschke)
+* LUCENE-6949: fix (potential) resource leak in SynonymFilterFactory
+ (https://scan.coverity.com/projects/5620 CID 120656)
+ (Christine Poerschke, Coverity Scan (via Rishabh Patel))
+
======================= Lucene 5.4.0 =======================
New Features
Modified: lucene/dev/trunk/lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymFilterFactory.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymFilterFactory.java?rev=1722856&r1=1722855&r2=1722856&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymFilterFactory.java (original)
+++ lucene/dev/trunk/lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymFilterFactory.java Mon Jan 4 12:19:38 2016
@@ -171,7 +171,9 @@ public class SynonymFilterFactory extend
List<String> files = splitFileNames(synonyms);
for (String file : files) {
decoder.reset();
- parser.parse(new InputStreamReader(loader.openResource(file), decoder));
+ try (final Reader isr = new InputStreamReader(loader.openResource(file), decoder)) {
+ parser.parse(isr);
+ }
}
return parser.build();
}