[GitHub] [dubbo-go] zouyx commented on a change in pull request #685: Ftr: add TLS support

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #685:
URL: https://github.com/apache/dubbo-go/pull/685#discussion_r469165358



##########
File path: config/consumer_config.go
##########
@@ -34,6 +33,10 @@ import (
 	"github.com/apache/dubbo-go/common/yaml"
 )
 
+const (
+	MaxWheelTimeSpan = 900e9 // 900s, 15 minute

Review comment:
       honestly , I don't think this is a good idea.
   
   In this case, getty developer changed the variable scope, we don't know.
   
   So if this variable scope is `dubbo-go` , i suggest keep it in `dubbo-go` is better.

##########
File path: config/consumer_config.go
##########
@@ -34,6 +33,10 @@ import (
 	"github.com/apache/dubbo-go/common/yaml"
 )
 
+const (
+	MaxWheelTimeSpan = 900e9 // 900s, 15 minute

Review comment:
       Honestly , I don't think this is a good idea.
   
   In this case, getty developer changed the variable scope, we don't know.
   
   So if this variable scope is `dubbo-go` , i suggest keep it in `dubbo-go` is better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org