You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/23 06:27:01 UTC
[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #408:
[ISSUE #407] feat: reuse bytes.Buffer
xujianhai666 opened a new pull request #408: [ISSUE #407] feat: reuse bytes.Buffer
URL: https://github.com/apache/rocketmq-client-go/pull/408
- use sync.pool of bytes.Buffer instead of new
Closes #407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #408: [ISSUE
#407] feat: reuse bytes.Buffer
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #408: [ISSUE #407] feat: reuse bytes.Buffer
URL: https://github.com/apache/rocketmq-client-go/pull/408
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #408: [ISSUE
#407] feat: reuse bytes.Buffer
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #408: [ISSUE #407] feat: reuse bytes.Buffer
URL: https://github.com/apache/rocketmq-client-go/pull/408#issuecomment-589965765
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/408?src=pr&el=h1) Report
> Merging [#408](https://codecov.io/gh/apache/rocketmq-client-go/pull/408?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/f9e5f75986e825e6e75305461bb21097b82774b7?src=pr&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `93.33%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/408?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #408 +/- ##
==========================================
- Coverage 25.19% 25.06% -0.13%
==========================================
Files 47 48 +1
Lines 5474 5486 +12
==========================================
- Hits 1379 1375 -4
- Misses 3907 3924 +17
+ Partials 188 187 -1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/408?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [primitive/pool.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/408/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL3Bvb2wuZ28=) | `58.82% <100%> (+46.32%)` | :arrow_up: |
| [primitive/message.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/408/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL21lc3NhZ2UuZ28=) | `25.31% <83.33%> (+0.31%)` | :arrow_up: |
| [consumer/consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/408/diff?src=pr&el=tree#diff-Y29uc3VtZXIvY29uc3VtZXIuZ28=) | `16.25% <0%> (-1.72%)` | :arrow_down: |
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/408/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `12.41% <0%> (-0.4%)` | :arrow_down: |
| [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/408/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.23% <0%> (-0.01%)` | :arrow_down: |
| [primitive/errors.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/408/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL2Vycm9ycy5nbw==) | `0% <0%> (ø)` | |
| [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/408/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.87% <0%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/408?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/408?src=pr&el=footer). Last update [f9e5f75...831ae72](https://codecov.io/gh/apache/rocketmq-client-go/pull/408?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services