You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/08/28 07:09:52 UTC
[jclouds] Upgrade to Guava 15.0-rc1 (#133)
Release notes:
https://code.google.com/p/guava-libraries/wiki/Release15
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds guava-15.0-rc1
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/133
-- Commit Summary --
* Upgrade to Guava 15.0-rc1
-- File Changes --
M core/pom.xml (2)
M core/src/main/java/org/jclouds/concurrent/config/WithSubmissionTrace.java (31)
M core/src/test/java/org/jclouds/json/internal/DeserializationConstructorAndReflectiveTypeAdapterFactoryTest.java (3)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/133.patch
https://github.com/jclouds/jclouds/pull/133.diff
Re: [jclouds] Upgrade to Guava 15.0-rc1 (#133)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #646](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/646/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/133#issuecomment-23393265
Re: [jclouds] Upgrade to Guava 15.0-rc1 (#133)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master. Also ran the S3 integration tests to gain more code coverage.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/133#issuecomment-23841246
Re: [jclouds] Upgrade to Guava 15.0-rc1 (#133)
Posted by Andrew Gaul <no...@github.com>.
> @@ -250,4 +252,15 @@ public T get(long arg0, TimeUnit arg1) throws InterruptedException, ExecutionExc
> }
> }
>
> + private static class ListenableScheduledFuture<T> extends ScheduledFuture<T>
These classes capture the stack trace of the caller for debugging purposes. I don't know if we strictly need these classes, but this commit is the minimum to pass unit tests with Guava 15.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/133/files#r6080110
Re: [jclouds] Upgrade to Guava 15.0-rc1 (#133)
Posted by Andrew Phillips <no...@github.com>.
Looks like this is causing regressions in labs:
https://jclouds.ci.cloudbees.com/job/jclouds-labs/229/testReport/
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/133#issuecomment-23915917
Re: [jclouds] Upgrade to Guava 15.0-rc1 (#133)
Posted by Andrew Phillips <no...@github.com>.
The labs regression seems to be causing downstream failures in Karaf:
https://jclouds.ci.cloudbees.com/job/jclouds-karaf/358/testReport/
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/133#issuecomment-23915993
Re: [jclouds] Upgrade to Guava 15.0-rc1 (#133)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #185](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/185/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/133#issuecomment-23393280
Re: [jclouds] Upgrade to Guava 15.0-rc1 (#133)
Posted by Andrew Phillips <no...@github.com>.
> @@ -250,4 +252,15 @@ public T get(long arg0, TimeUnit arg1) throws InterruptedException, ExecutionExc
> }
> }
>
> + private static class ListenableScheduledFuture<T> extends ScheduledFuture<T>
Do we _need_ ListenableScheduledFuture anywhere or was the old code simply incompatible with Guava 15 (I notice LSF is a new interface in 15)..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/133/files#r6032110
Re: [jclouds] Upgrade to Guava 15.0-rc1 (#133)
Posted by Andrew Phillips <no...@github.com>.
> Sorry I missed this
No need to be sorry, if you ask me - comes with multiple dependent projects. Thanks for fixing!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/133#issuecomment-23978894
Re: [jclouds] Upgrade to Guava 15.0-rc1 (#133)
Posted by Andrew Gaul <no...@github.com>.
Upgraded labs and karaf to Guava 15.0-rc1. Ran labs tests which passed. Karaf had its usual fit. Sorry I missed this; I thought we keyed off of the parent dependencies in master.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/133#issuecomment-23953376