You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by nickva <gi...@git.apache.org> on 2018/06/20 21:23:00 UTC

[GitHub] couchdb-snappy pull request #7: Build with Erlang 21

GitHub user nickva opened a pull request:

    https://github.com/apache/couchdb-snappy/pull/7

    Build with Erlang 21

    Issue #1396

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-snappy allow-erlang-21

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-snappy/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 57b5e25574944ab5bf387f630dccfb37f4c6b51c
Author: Nick Vatamaniuc <va...@...>
Date:   2018-06-20T21:15:14Z

    Build with Erlang 21
    
    Issue #1396

----


---

[GitHub] couchdb-snappy issue #7: Build with Erlang 21

Posted by davisp <gi...@git.apache.org>.

Github user davisp commented on the issue:

    https://github.com/apache/couchdb-snappy/pull/7
  
    Is it normal for all of the tests to fail?


---

[GitHub] couchdb-snappy issue #7: Build with Erlang 21

Posted by nickva <gi...@git.apache.org>.

Github user nickva commented on the issue:

    https://github.com/apache/couchdb-snappy/pull/7
  
    Yap, merged it via ASF. Still not sure why build failed. I had tried compiling with rebar3 locally and that worked as well. A different C compiler or libc version... who knows...


---

[GitHub] couchdb-snappy issue #7: Build with Erlang 21

Posted by nickva <gi...@git.apache.org>.

Github user nickva commented on the issue:

    https://github.com/apache/couchdb-snappy/pull/7
  
    Not sure why travis doesn't work but local tests do pass with 21:
    ```
     make check
    rebar compile
    ==> snappy (compile)
    rebar eunit
    ==> snappy (eunit)
    Compiled src/snappy.erl
    Compiled test/snappy_tests.erl
    ======================== EUnit ========================
    module 'snappy'
      module 'snappy_tests'
        snappy_tests: compression_test_...ok
        snappy_tests: decompression_test_...ok
        [done in 0.496 s]
      [done in 0.496 s]
    =======================================================
      2 tests passed.
    ```


---

[GitHub] couchdb-snappy issue #7: Build with Erlang 21

Posted by davisp <gi...@git.apache.org>.

Github user davisp commented on the issue:

    https://github.com/apache/couchdb-snappy/pull/7
  
    Oh, its a permissions thing. Ignore my rambling.


---

[GitHub] couchdb-snappy issue #7: Build with Erlang 21

Posted by davisp <gi...@git.apache.org>.

Github user davisp commented on the issue:

    https://github.com/apache/couchdb-snappy/pull/7
  
    Oh, except it looks like we have to make them pass for the merge button?


---

[GitHub] couchdb-snappy issue #7: Build with Erlang 21

Posted by nickva <gi...@git.apache.org>.

Github user nickva commented on the issue:

    https://github.com/apache/couchdb-snappy/pull/7
  
    Yap all travis builds fail apparently now. Here is a change to the README file: https://travis-ci.org/apache/couchdb-snappy/builds/395127559?utm_source=github_status&utm_medium=notification


---

[GitHub] couchdb-snappy issue #7: Build with Erlang 21

Posted by davisp <gi...@git.apache.org>.

Github user davisp commented on the issue:

    https://github.com/apache/couchdb-snappy/pull/7
  
    Tested locally and it works so will ignore it.


---

[GitHub] couchdb-snappy issue #7: Build with Erlang 21

Posted by nickva <gi...@git.apache.org>.

Github user nickva commented on the issue:

    https://github.com/apache/couchdb-snappy/pull/7
  
    Trying to use rebar3 maybe and it can't build the nif properly?


---