You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Ufuk Celebi (JIRA)" <ji...@apache.org> on 2014/07/29 16:10:39 UTC
[jira] [Closed] (FLINK-1034) Inconsistent naming of DataSet
reduceGroup and GroupReduceFunction
[ https://issues.apache.org/jira/browse/FLINK-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ufuk Celebi closed FLINK-1034.
------------------------------
Resolution: Won't Fix
> Inconsistent naming of DataSet reduceGroup and GroupReduceFunction
> ------------------------------------------------------------------
>
> Key: FLINK-1034
> URL: https://issues.apache.org/jira/browse/FLINK-1034
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Reporter: Ufuk Celebi
> Priority: Trivial
> Labels: breaking-api
>
> I don't know if it is on purpose or not, but I found it to be inconsistent and sometimes also confusing:
> Why not
> {code:java}
> input.groupReduce(new GroupReduceFunction() {...})
> {code}
> instead of the current
> {code:java}
> input.reduceGroup(new GroupReduceFunction() {...})
> {code}
> I think it's the same line of thinking, which results in overriding a {{reduce}} method in {{GroupReduceFunction}} instead of a {{groupReduce}} method.
> Is there a nice way to unify this?
--
This message was sent by Atlassian JIRA
(v6.2#6252)