You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/07/05 22:31:47 UTC

Re: Review Request 59761: Added master and agent flags to specify domain.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59761/
-----------------------------------------------------------

(Updated July 5, 2017, 10:31 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Rebase.


Bugs: MESOS-7610
    https://issues.apache.org/jira/browse/MESOS-7610


Repository: mesos


Description
-------

Added master and agent flags to specify domain.


Diffs (updated)
-----

  docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c 
  src/common/parse.hpp 64eabf89f81a6708cfac89081e0d9f9586721693 
  src/master/flags.hpp 8a9bd2dfa513f1de85dab2cc3cc1d78e80293837 
  src/master/flags.cpp ca5f02c728a9f39abbbee59fa169f95d20c69d3d 
  src/slave/flags.hpp c6803eb54e09a5497755e1e5fef2872193eacba6 
  src/slave/flags.cpp 398768656b5fa3b7c85474de2b4b008bf7b85cb3 


Diff: https://reviews.apache.org/r/59761/diff/3/

Changes: https://reviews.apache.org/r/59761/diff/2-3/


Testing
-------

`make check`


Thanks,

Neil Conway


Re: Review Request 59761: Added master and agent flags to specify domain.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59761/#review179718
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On July 5, 2017, 10:31 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59761/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 10:31 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7610
>     https://issues.apache.org/jira/browse/MESOS-7610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added master and agent flags to specify domain.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c 
>   src/common/parse.hpp 64eabf89f81a6708cfac89081e0d9f9586721693 
>   src/master/flags.hpp 8a9bd2dfa513f1de85dab2cc3cc1d78e80293837 
>   src/master/flags.cpp ca5f02c728a9f39abbbee59fa169f95d20c69d3d 
>   src/slave/flags.hpp c6803eb54e09a5497755e1e5fef2872193eacba6 
>   src/slave/flags.cpp 398768656b5fa3b7c85474de2b4b008bf7b85cb3 
> 
> 
> Diff: https://reviews.apache.org/r/59761/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Re: Review Request 59761: Added master and agent flags to specify domain.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59761/
-----------------------------------------------------------

(Updated July 7, 2017, 4:20 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Rebase.


Bugs: MESOS-7610
    https://issues.apache.org/jira/browse/MESOS-7610


Repository: mesos


Description
-------

Added master and agent flags to specify domain.


Diffs (updated)
-----

  docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c 
  src/common/parse.hpp 64eabf89f81a6708cfac89081e0d9f9586721693 
  src/master/flags.hpp 8a9bd2dfa513f1de85dab2cc3cc1d78e80293837 
  src/master/flags.cpp ca5f02c728a9f39abbbee59fa169f95d20c69d3d 
  src/slave/flags.hpp 858876fe86cc50cb3655b06071db6450916cb814 
  src/slave/flags.cpp 74df647cc4f1161d061f0349011ce070db3a9789 


Diff: https://reviews.apache.org/r/59761/diff/4/

Changes: https://reviews.apache.org/r/59761/diff/3-4/


Testing
-------

`make check`


Thanks,

Neil Conway