You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/10/12 07:10:18 UTC
Review Request 39216: Rename http_api_tests.cpp to
scheduler_http_api_tests.cpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39216/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-3594
https://issues.apache.org/jira/browse/MESOS-3594
Repository: mesos
Description
-------
Rename http_api_tests.cpp to scheduler_http_api_tests.cpp
Diffs
-----
src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
src/tests/http_api_tests.cpp df87afe01edc27504c973efbc4061cfb7cc808f5
Diff: https://reviews.apache.org/r/39216/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 39216: Rename http_api_tests.cpp to
scheduler_http_api_tests.cpp
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39216/#review102210
-----------------------------------------------------------
Ship it!
Ship It!
- Jian Qiu
On Oct. 12, 2015, 5:10 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39216/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 5:10 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3594
> https://issues.apache.org/jira/browse/MESOS-3594
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename http_api_tests.cpp to scheduler_http_api_tests.cpp
>
>
> Diffs
> -----
>
> src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
> src/tests/http_api_tests.cpp df87afe01edc27504c973efbc4061cfb7cc808f5
>
> Diff: https://reviews.apache.org/r/39216/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39216: Rename http_api_tests.cpp to
scheduler_http_api_tests.cpp
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39216/#review102208
-----------------------------------------------------------
Ship it!
LGTM. Thanks for resolving this tech-debt.
- Anand Mazumdar
On Oct. 12, 2015, 5:10 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39216/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 5:10 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3594
> https://issues.apache.org/jira/browse/MESOS-3594
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename http_api_tests.cpp to scheduler_http_api_tests.cpp
>
>
> Diffs
> -----
>
> src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
> src/tests/http_api_tests.cpp df87afe01edc27504c973efbc4061cfb7cc808f5
>
> Diff: https://reviews.apache.org/r/39216/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39216: Rename http_api_tests.cpp to
scheduler_http_api_tests.cpp
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39216/#review102211
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39216]
All tests passed.
- Mesos ReviewBot
On Oct. 12, 2015, 5:10 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39216/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 5:10 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3594
> https://issues.apache.org/jira/browse/MESOS-3594
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename http_api_tests.cpp to scheduler_http_api_tests.cpp
>
>
> Diffs
> -----
>
> src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
> src/tests/http_api_tests.cpp df87afe01edc27504c973efbc4061cfb7cc808f5
>
> Diff: https://reviews.apache.org/r/39216/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39216: Rename http_api_tests.cpp to
scheduler_http_api_tests.cpp
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39216/
-----------------------------------------------------------
(Updated 十月 12, 2015, 5:10 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3594
https://issues.apache.org/jira/browse/MESOS-3594
Repository: mesos
Description
-------
Rename http_api_tests.cpp to scheduler_http_api_tests.cpp
Diffs
-----
src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
src/tests/http_api_tests.cpp df87afe01edc27504c973efbc4061cfb7cc808f5
Diff: https://reviews.apache.org/r/39216/diff/
Testing (updated)
-------
make
make check
Thanks,
Guangya Liu