You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Michael Osipov <mi...@apache.org> on 2020/07/18 12:36:24 UTC
[VOTE] Release Maven Resolver version 1.5.0
Hi,
We solved 15 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12348349
There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissues
Staging repo:
https://repository.apache.org/content/repositories/maven-1596/
https://repository.apache.org/content/repositories/maven-1596/org/apache/maven/resolver/maven-resolver/1.5.0/maven-resolver-1.5.0-source-release.zip
Source release checksum(s):
maven-resolver-1.5.0-source-release.zip
sha512:
b7a6585944be24036af82b2e0a73609dbe9e73338563971739631c766fcc681e78e881cbf74f6c13ead1db07a07f5db01b5bd4655eafc69bbf71c9cbe259a2cd
Staging site:
https://maven.apache.org/resolver-archives/resolver-LATEST/
Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Maven Resolver version 1.5.0
Posted by Michael Osipov <mi...@apache.org>.
Am 2020-07-19 um 20:40 schrieb Elliotte Rusty Harold:
> I don't fully grok the issue at hand and do not feel comfortable
> deciding between whether this works or not. When I try to write
> complicated multithreaded code that needs to synchronize between
> threads, devs who truly understand this usually find bugs in my work
> without looking very hard.
>
> It would be safest for you and Tibor to resolve this before the plugin
> is released. If that doesn't happen, we can look for a real
> multi-threading expert (not me) to way in on this.
This is strange, there has been a discussions for weeks in JIRA, no
other committer chimed in. I have created a PR, yet you were the only
one to approve. I have even asked on the ML if there is an objection,
none came. Now that I have merged everything and triggered the release
people start complaining that this is faulty, why don't do you do this
and that? Seriously? I gave the community plenty of time to express
their objections and even provide better solutions, but nothing has
happened. Unless Tibor can provide me explicit code what makes the given
implementation better/correct according to SyncContextFactory, I see no
easier way to provide a fix. Even worse that we didn't care for years
about this annoying bug, but no one stood up to fix this in some fashion.
After this simple fix I wanted to look into a Redisson-based solution
for true multiprocess concurrency because it does provide all necessary
locks, but frankly I won't spend any of my free time on it.
M
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Maven Resolver version 1.5.0
Posted by Elliotte Rusty Harold <el...@ibiblio.org>.
I don't fully grok the issue at hand and do not feel comfortable
deciding between whether this works or not. When I try to write
complicated multithreaded code that needs to synchronize between
threads, devs who truly understand this usually find bugs in my work
without looking very hard.
It would be safest for you and Tibor to resolve this before the plugin
is released. If that doesn't happen, we can look for a real
multi-threading expert (not me) to way in on this.
On Sun, Jul 19, 2020 at 3:52 PM Michael Osipov <mi...@apache.org> wrote:
>
> Am 2020-07-18 um 19:17 schrieb Elliotte Rusty Harold:
> > Michael,
> >
> > Could you address Tibor's concerns about your solution to [MRESOLVER-123]?
> >
> > https://github.com/apache/maven-resolver/pull/65
>
> So I did, the code complies to the contract of the SynContextFactory
> interface as well as to the contract of ReentrantReadWriteLock. I truly
> don't understand Tibor's concerns. He questions the design of
> SyncContextFactory, but this is the wrong forum to discuss it. It should
> be separate issue.
>
> Do you have any concerns since you approved the PR?
>
> M
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Elliotte Rusty Harold
elharo@ibiblio.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Maven Resolver version 1.5.0
Posted by Michael Osipov <mi...@apache.org>.
Am 2020-07-18 um 19:17 schrieb Elliotte Rusty Harold:
> Michael,
>
> Could you address Tibor's concerns about your solution to [MRESOLVER-123]?
>
> https://github.com/apache/maven-resolver/pull/65
So I did, the code complies to the contract of the SynContextFactory
interface as well as to the contract of ReentrantReadWriteLock. I truly
don't understand Tibor's concerns. He questions the design of
SyncContextFactory, but this is the wrong forum to discuss it. It should
be separate issue.
Do you have any concerns since you approved the PR?
M
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Maven Resolver version 1.5.0
Posted by Elliotte Rusty Harold <el...@ibiblio.org>.
Michael,
Could you address Tibor's concerns about your solution to [MRESOLVER-123]?
https://github.com/apache/maven-resolver/pull/65
On Sat, Jul 18, 2020 at 12:36 PM Michael Osipov <mi...@apache.org> wrote:
>
> Hi,
>
> We solved 15 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12348349
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissues
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1596/
> https://repository.apache.org/content/repositories/maven-1596/org/apache/maven/resolver/maven-resolver/1.5.0/maven-resolver-1.5.0-source-release.zip
>
> Source release checksum(s):
> maven-resolver-1.5.0-source-release.zip
> sha512:
> b7a6585944be24036af82b2e0a73609dbe9e73338563971739631c766fcc681e78e881cbf74f6c13ead1db07a07f5db01b5bd4655eafc69bbf71c9cbe259a2cd
>
> Staging site:
> https://maven.apache.org/resolver-archives/resolver-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Elliotte Rusty Harold
elharo@ibiblio.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Maven Resolver version 1.5.0
Posted by Sylwester Lachiewicz <sl...@gmail.com>.
+1
Tested with Maven from the master branch. Normal ITs run was successful.
Unfortunately, I was unable to run our ITS parallel (-T 5C) - whether using
the new Resolver version or the previous one. Usually, tests on Windows
result in errors
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/parallel/
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/resolver-1.5/
BR
Sylwester
sob., 18 lip 2020 o 14:36 Michael Osipov <mi...@apache.org> napisał(a):
> Hi,
>
> We solved 15 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12348349
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissues
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1596/
>
> https://repository.apache.org/content/repositories/maven-1596/org/apache/maven/resolver/maven-resolver/1.5.0/maven-resolver-1.5.0-source-release.zip
>
> Source release checksum(s):
> maven-resolver-1.5.0-source-release.zip
> sha512:
>
> b7a6585944be24036af82b2e0a73609dbe9e73338563971739631c766fcc681e78e881cbf74f6c13ead1db07a07f5db01b5bd4655eafc69bbf71c9cbe259a2cd
>
> Staging site:
> https://maven.apache.org/resolver-archives/resolver-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>