You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Cameron Gandevia <cg...@gmail.com> on 2013/02/21 23:43:49 UTC

Re: Review Request: FLUME-1765 - Add Load Balancing Support to Log4jAppender

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8328/
-----------------------------------------------------------

(Updated Feb. 21, 2013, 10:43 p.m.)


Review request for Flume.


Changes
-------

Removed white spaces from Test classes


Description
-------

The Log4jAppender should be extended to use the LoadBalancingRpcClient allowing users to configure a load balancing log4jappender


Diffs (updated)
-----

  flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java PRE-CREATION 
  flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 315a68c 
  flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java PRE-CREATION 
  flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-backoff-log4jtest.properties PRE-CREATION 
  flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-rnd-log4jtest.properties PRE-CREATION 
  flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancinglog4jtest.properties PRE-CREATION 
  flume-ng-doc/sphinx/FlumeUserGuide.rst 8eb3734 

Diff: https://reviews.apache.org/r/8328/diff/


Testing
-------


Thanks,

Cameron Gandevia


Re: Review Request: FLUME-1765 - Add Load Balancing Support to Log4jAppender

Posted by Cameron Gandevia <cg...@gmail.com>.

> On Feb. 21, 2013, 10:46 p.m., Hari Shreedharan wrote:
> > Cameron:
> > 
> > Please attach the patch to the jira to confirm that you have granted ASF the license to your patch. Thanks!

Done


- Cameron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8328/#review16887
-----------------------------------------------------------


On Feb. 21, 2013, 10:43 p.m., Cameron Gandevia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8328/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 10:43 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> The Log4jAppender should be extended to use the LoadBalancingRpcClient allowing users to configure a load balancing log4jappender
> 
> 
> Diffs
> -----
> 
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java PRE-CREATION 
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 315a68c 
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java PRE-CREATION 
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-backoff-log4jtest.properties PRE-CREATION 
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-rnd-log4jtest.properties PRE-CREATION 
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancinglog4jtest.properties PRE-CREATION 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 8eb3734 
> 
> Diff: https://reviews.apache.org/r/8328/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cameron Gandevia
> 
>


Re: Review Request: FLUME-1765 - Add Load Balancing Support to Log4jAppender

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8328/#review16887
-----------------------------------------------------------


Cameron:

Please attach the patch to the jira to confirm that you have granted ASF the license to your patch. Thanks!

- Hari Shreedharan


On Feb. 21, 2013, 10:43 p.m., Cameron Gandevia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8328/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 10:43 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> The Log4jAppender should be extended to use the LoadBalancingRpcClient allowing users to configure a load balancing log4jappender
> 
> 
> Diffs
> -----
> 
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java PRE-CREATION 
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 315a68c 
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java PRE-CREATION 
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-backoff-log4jtest.properties PRE-CREATION 
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-rnd-log4jtest.properties PRE-CREATION 
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancinglog4jtest.properties PRE-CREATION 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 8eb3734 
> 
> Diff: https://reviews.apache.org/r/8328/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cameron Gandevia
> 
>