[GitHub] [hbase] wchevreuil commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs
URL: https://github.com/apache/hbase/pull/884#discussion_r351854626
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
 ##########
 @@ -159,7 +159,7 @@ private void scheduleRelogin(Throwable error) {
         @Override
         public void run() {
           try {
-            if (shouldAuthenticateOverKrb()) {
+            if (provider.isKerberos()) {
 
 Review comment:
   Here and also on _BlockingRpcConnection_ we are still referring to kerberos, although we are trying to make Rpc connection logic agnostic to authentication specifics. Maybe we could define _handlefailure_ method on the provider interface, and each implementation would decide what sorts of cleanup it's needed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services