[GitHub] [arrow] JabariBooker commented on a diff in pull request #13109: ARROW-15365: [Python] Expose full cast options in the pyarrow.compute.cast function

[GitBox <gi...@apache.org>]

JabariBooker commented on code in PR #13109:
URL: https://github.com/apache/arrow/pull/13109#discussion_r899462686


##########
python/pyarrow/tests/test_compute.py:
##########
@@ -1702,13 +1702,37 @@ def test_logical():
 
 
 def test_cast():
+    arr = pa.array([1, 2, 3, 4], type='int64')
+    options = pc.CastOptions(pa.int8())
+
+    with pytest.raises(ValueError):
+        pc.cast(arr, target_type=None)
+
+    with pytest.raises(ValueError):
+        pc.cast(arr, 'int32', safe=True, options=options)
+
+    with pytest.raises(ValueError):
+        pc.cast(arr, 'int32', safe=False, options=options)
+
+    assert pc.cast(arr, 'int8', options=options) == pa.array(
+        [1, 2, 3, 4], type='int8')
+
     arr = pa.array([2 ** 63 - 1], type='int64')
+    options = pc.CastOptions(pa.int32())
+    allow_overflow_options = pc.CastOptions(
+        pa.int32(), allow_int_overflow=True)
 
     with pytest.raises(pa.ArrowInvalid):
         pc.cast(arr, 'int32')
 
+    with pytest.raises(pa.ArrowInvalid):
+        pc.cast(arr, 'int32', options)

Review Comment:
   This was intended to ensure that passing a `CastOptions` object like this would fail in the same way `safe=options` would.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org